kernel/linux.git/drivers/staging/crystalhd, branch v3.4.34

Remove all #inclusions of asm/system.h

2012-03-28T17:30:03+00:00

Remove all #inclusions of asm/system.h preparatory to splitting and killing it. Performed with the following command: perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *` Signed-off-by: David Howells

Add #includes needed to permit the removal of asm/system.h

2012-03-28T17:30:03+00:00

asm/system.h is a cause of circular dependency problems because it contains commonly used primitive stuff like barrier definitions and uncommonly used stuff like switch_to() that might require MMU definitions. asm/system.h has been disintegrated by this point on all arches into the following common segments: (1) asm/barrier.h Moved memory barrier definitions here. (2) asm/cmpxchg.h Moved xchg() and cmpxchg() here. #included in asm/atomic.h. (3) asm/bug.h Moved die() and similar here. (4) asm/exec.h Moved arch_align_stack() here. (5) asm/elf.h Moved AT_VECTOR_SIZE_ARCH here. (6) asm/switch_to.h Moved switch_to() here. Signed-off-by: David Howells

staging: crystalhd: Fix typo in crystalhd_hw.c

2012-03-08T17:57:38+00:00

Correct spelling "interal" to "internal" in drivers/staging/crystalhd/crystalhd_hw.c Signed-off-by: Masanari Iida Signed-off-by: Greg Kroah-Hartman

Staging: crystalhd: Remove unused header bc_dts_types.h

2012-02-29T23:55:15+00:00

The header bc_dts_types is not used, so we can remove it. Signed-off-by: Jorgyano Vieira Signed-off-by: Greg Kroah-Hartman

Staging: crystalhd: Replace the local includes with global header

2012-02-29T23:54:39+00:00

This patch replaces the local includes with the global header. So the the crystalhd.h will be the only header included by the other files. Signed-off-by: Jorgyano Vieira Signed-off-by: Greg Kroah-Hartman

Staging: crystalhd: Add global header

2012-02-29T23:54:39+00:00

In the crystalhd_cmds.h there was a struct dependence bug: the struct crystalhd_adp (which is declared on crystalhd_lnx.h) is used on the crystalhd_cmd struct, however the crystalhd_lnx.h is never included on crystalhd_cmds.h at all. Including the crystalhd_lnx.h on crystalhd_cmds.h breaks the build, many dependencies error occurrs, most of the type "error: 'struct bar' has no member named 'foo'", so I decided to reorganize the headers by adding a global header. The gobal header crystalhd.h includes all the local headers. The idea is that the crystalhd header will be the only included by the others files, this will avoid the mess of many #include levels. The order of the headers included by crystalhd.h considers the dependencies among the headers. Signed-off-by: Jorgyano Vieira Signed-off-by: Greg Kroah-Hartman

Staging: crystalhd: Get rid of unecessary BCMLOG_ENTER macro

2012-02-24T19:53:10+00:00

The BCMLOG_ENTER macro is used only in five functions, perhaps it is remainder of debugging some specific problem, now, this macro don't seems to be useful, so it should be removed. Signed-off-by: Jorgyano Vieira Signed-off-by: Greg Kroah-Hartman

Staging: crystalhd: crystalhd_misc: Get rid of unused macro

2012-02-24T19:53:09+00:00

The BCMLOG_LEAVE macro is not used, so there is no reason to keep it. Signed-off-by: Jorgyano Vieira Signed-off-by: Greg Kroah-Hartman

Staging: crystalhd: crystalhd_misc: improved debug macros

2012-02-16T01:21:42+00:00

Improvement of debug macros to ensure safe use on if/else statements. Signed-off-by: Jorgyano Vieira Acked-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: precedence bug in crystalhd_stop_tx_dma_engine()

2012-02-09T17:13:55+00:00

The intent here is to see if we have cleared the DMA_START_BIT flag. We clear it a couple lines later. The current code has a precedence bug so it is equivalent to "if (!dma_cntrl) { ...". Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman