kernel/linux.git/drivers/soc/xilinx, branch v5.10.257Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v5.10.2572024-08-19T03:41:07+00:00drivers: soc: xilinx: check return status of get_api_version()2024-08-19T03:41:07+00:00Jay Buddhabhattijay.buddhabhatti@amd.com2024-05-15T11:23:45+00:00urn:sha1:6bb9cc6e25942b13ebe1e2241b3c5b6317031793
[ Upstream commit 9b003e14801cf85a8cebeddc87bc9fc77100fdce ]
Currently return status is not getting checked for get_api_version
and because of that for x86 arch we are getting below smatch error.
CC drivers/soc/xilinx/zynqmp_power.o
drivers/soc/xilinx/zynqmp_power.c: In function 'zynqmp_pm_probe':
drivers/soc/xilinx/zynqmp_power.c:295:12: warning: 'pm_api_version' is
used uninitialized [-Wuninitialized]
295 | if (pm_api_version < ZYNQMP_PM_VERSION)
| ^
CHECK drivers/soc/xilinx/zynqmp_power.c
drivers/soc/xilinx/zynqmp_power.c:295 zynqmp_pm_probe() error:
uninitialized symbol 'pm_api_version'.
So, check return status of pm_get_api_version and return error in case
of failure to avoid checking uninitialized pm_api_version variable.
Fixes: b9b3a8be28b3 ("firmware: xilinx: Remove eemi ops for get_api_version")
Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240515112345.24673-1-jay.buddhabhatti@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
soc: xilinx: move PM_INIT_FINALIZE to zynqmp_pm_domains driver2024-08-19T03:41:07+00:00Michael Tretterm.tretter@pengutronix.de2021-08-25T15:03:10+00:00urn:sha1:79ec4cde1d8a6128382aa9d94a5ec83cbc4b3708
[ Upstream commit 7fd890b89dea55eb5866640eb8befad26d558161 ]
PM_INIT_FINALIZE tells the PMU FW that Linux is able to handle the power
management nodes that are provided by the PMU FW. Nodes that are not
requested are shut down after this call.
Calling PM_INIT_FINALIZE from the zynqmp_power driver is wrong. The PM
node request mechanism is implemented in the zynqmp_pm_domains driver,
which must also call PM_INIT_FINALIZE.
Due to the behavior of the PMU FW, all devices must be powered up before
PM_INIT_FINALIZE is called, because otherwise the devices might
misbehave. Calling PM_INIT_FINALIZE from the sync_state device callback
ensures that all users probed successfully before the PMU FW is allowed
to power off unused domains.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Rajan Vaja <rajan.vaja@xilinx.com>
Link: https://lore.kernel.org/r/20210825150313.4033156-2-m.tretter@pengutronix.de
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Stable-dep-of: 9b003e14801c ("drivers: soc: xilinx: check return status of get_api_version()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
soc: xilinx: Fix error code in zynqmp_pm_probe()2020-06-18T08:07:17+00:00Dan Carpenterdan.carpenter@oracle.com2020-06-05T11:00:20+00:00urn:sha1:a6f2f0fdc73aacc6e10ae48ae78634dba26702d4
This should be returning PTR_ERR() but it returns IS_ERR() instead.
Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20200605110020.GA978434@mwanda
firmware: xilinx: Remove eemi ops for set_requirement2020-04-28T13:45:09+00:00Rajan Vajarajan.vaja@xilinx.com2020-04-24T20:58:00+00:00urn:sha1:cbbbda71fe37fe70e610d5ec3977fc6a096280ed
Use direct function call instead of using eemi ops for
set_requirement.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-19-git-send-email-jolly.shah@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
firmware: xilinx: Remove eemi ops for release_node2020-04-28T13:45:09+00:00Rajan Vajarajan.vaja@xilinx.com2020-04-24T20:57:59+00:00urn:sha1:07fb1a4619fcb35f79d0adc13c8678f7726337ef
Use direct function call instead of using eemi ops for release_node.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-18-git-send-email-jolly.shah@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
firmware: xilinx: Remove eemi ops for request_node2020-04-28T13:45:09+00:00Rajan Vajarajan.vaja@xilinx.com2020-04-24T20:57:58+00:00urn:sha1:bf8b27ed2324b5108439593dcfb9ab264a745ee7
Use direct function call instead of using eemi ops for request_node.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-17-git-send-email-jolly.shah@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
firmware: xilinx: Remove eemi ops for set_suspend_mode2020-04-28T13:45:08+00:00Rajan Vajarajan.vaja@xilinx.com2020-04-24T20:57:57+00:00urn:sha1:951d0a97e41caff96c180ca416093276bfd9a4fd
Use direct function call instead of eemi ops for set_suspend_mode.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-16-git-send-email-jolly.shah@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
firmware: xilinx: Remove eemi ops for init_finalize2020-04-28T13:45:08+00:00Rajan Vajarajan.vaja@xilinx.com2020-04-24T20:57:56+00:00urn:sha1:9474da950d1e39f71cbfeaba87367fa146635a88
Use direct function call instead of eemi ops for init_finalize.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-15-git-send-email-jolly.shah@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
firmware: xilinx: Remove eemi ops for get_api_version2020-04-28T13:38:38+00:00Rajan Vajarajan.vaja@xilinx.com2020-04-24T20:57:43+00:00urn:sha1:b9b3a8be28b31a3dbcb0ced07aa0d869f45cdb69
Use direct function calls instead of using eemi ops. So remove
eemi ops for get_api_version and use direct function call.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-2-git-send-email-jolly.shah@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers: soc: xilinx: fix firmware driver Kconfig dependency2020-04-15T06:15:55+00:00Arnd Bergmannarnd@arndb.de2020-04-08T15:52:15+00:00urn:sha1:d0384eedcde21276ac51f57c641f875605024b32
The firmware driver is optional, but the power driver depends on it,
which needs to be reflected in Kconfig to avoid link errors:
aarch64-linux-ld: drivers/soc/xilinx/zynqmp_power.o: in function `zynqmp_pm_isr':
zynqmp_power.c:(.text+0x284): undefined reference to `zynqmp_pm_invoke_fn'
The firmware driver can probably be allowed for compile-testing as
well, so it's best to drop the dependency on the ZYNQ platform
here and allow building as long as the firmware code is built-in.
Fixes: ab272643d723 ("drivers: soc: xilinx: Add ZynqMP PM driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20200408155224.2070880-1-arnd@arndb.de
Signed-off-by: Michal Simek <michal.simek@xilinx.com>