kernel/linux.git/drivers/slimbus, branch v5.4.50

slimbus: ngd: get drvdata from correct device

2020-06-24T15:50:22+00:00

[ Upstream commit b58c663059b484f7ff547d076a34cf6d7a302e56 ] Get drvdata directly from parent instead of ngd dev, as ngd dev can probe defer and previously set drvdata will become null. Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200417093618.7929-1-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin

slimbus: fix slim_tid_txn()

2019-08-18T10:56:10+00:00

fix below issue reported by coccicheck ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or || Looks like this was a typo, SLIM_MSG_MC_REQUEST_CHANGE_VALUE is command which requires transaction ID, so fix it, this also fix the warning. Reported-by: Hariprasad Kelam Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20190818093902.29993-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: qcom-ngd-ctrl: Add of_node_put() before return

2019-08-18T10:56:10+00:00

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Reviewed-by: Bjorn Andersson Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20190818093902.29993-2-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: core: generate uevent for non-dt only

2019-06-20T08:45:22+00:00

Rely on MODULE_ALIAS() for automatic kernel module loading, rather than basing it on the OF compatible. This ensures that drivers without of_device_id table, such as wcd9335, will be automatically loaded. Signed-off-by: Srinivas Kandagatla [bjorn: Added commit message] Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman

slimbus: remove redundant dev_err message

2019-06-20T08:45:22+00:00

devm_ioremap_resource already contains error message, so remove the redundant dev_err message Signed-off-by: Ding Xiang Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: fix kerneldoc comments

2019-06-10T16:44:21+00:00

The kerneldoc comments in drivers/slimbus/stream.c were not properly formatted, leading to a distinctly unsatisfying "no structured comments found" warning in the docs build. Sprinkle some asterisks around so that the comments will be properly recognized. Signed-off-by: Jonathan Corbet Signed-off-by: Greg Kroah-Hartman

slimbus: fix a potential NULL pointer dereference in of_qcom_slim_ngd_register

2019-04-25T20:23:06+00:00

In case platform_device_alloc fails, the fix returns an error code to avoid the NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: core: add missing spin_lock_init on txn_lock

2019-01-22T12:34:35+00:00

Add missing spin lock intialization this also fixes the spinlock bad magic warning. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: core: use slim_device_update_status() to update status

2019-01-22T12:34:35+00:00

use slim_device_update_status() instead of directly calling the device_status() callback. Move slim_device_update_status() before probe to avoid forward declaration too. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: core: do not call device_status under a lock

2019-01-22T12:34:34+00:00

Calling device_status callback under a lock would prevent drivers to do any slimbus trasactions which would invoke this lock like get_laddr(). Remove this unnecessary lock! Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman