kernel/linux.git/drivers/slimbus/messaging.c, branch v6.2

slimbus: messaging: fix typos in comments

2022-07-08T13:43:42+00:00

Spelling mistakes (triple letters) in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20220706101131.6934-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: check for valid transaction id

2021-08-13T08:22:30+00:00

In some usecases transaction ids are dynamically allocated inside the controller driver after sending the messages which have generic acknowledge responses. So check for this before refcounting pm_runtime. Without this we would end up imbalancing runtime pm count by doing pm_runtime_put() in both slim_do_transfer() and slim_msg_response() for a single pm_runtime_get() in slim_do_transfer() Fixes: d3062a210930 ("slimbus: messaging: add slim_alloc/free_txn_tid()") Cc: Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20210809082428.11236-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: start transaction ids from 1 instead of zero

2021-08-13T08:22:30+00:00

As tid is unsigned its hard to figure out if the tid is valid or invalid. So Start the transaction ids from 1 instead of zero so that we could differentiate between a valid tid and invalid tids This is useful in cases where controller would add a tid for controller specific transfers. Fixes: d3062a210930 ("slimbus: messaging: add slim_alloc/free_txn_tid()") Cc: Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20210809082428.11236-2-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: Fix fall-through warnings for Clang

2020-11-27T15:03:43+00:00

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20201127102451.17114-5-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: add slim_alloc/free_txn_tid()

2018-07-07T15:24:32+00:00

This patch adds slim_alloc_txn_tid() and slim_free_txn_tid() api to allow controllers like ngd to allocate tids for user specific commands. This also cleans up the existing code to use single place for tid allocations and free. This patch also make the tid allocation cyclic one, its very useful to track the transactions back during debug. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: initialize completion correctly

2018-07-07T15:23:12+00:00

slim_val_inf can contain random value from stack, make sure the completion is initialized to NULL while filling the msg. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy

2018-07-07T15:23:12+00:00

There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: messaging: pass correct wbuf

2018-07-07T15:23:12+00:00

There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: Fix out-of-bounds access in slim_slicesize()

2018-04-23T11:40:15+00:00

With gcc-4.1.2: slimbus/messaging.c: In function ‘slim_slicesize’: slimbus/messaging.c:186: warning: statement with no effect Indeed, clamp() is a macro not operating in-place, but returning the clamped value. Hence the value is not clamped at all, which may lead to an out-of-bounds access. Fix this by assigning the clamped value. Fixes: afbdcc7c384b0d44 ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Geert Uytterhoeven Cc: stable Signed-off-by: Greg Kroah-Hartman

slimbus: Fix missing unlock on error in slim_msg_response()

2018-01-09T16:00:13+00:00

Add the missing unlock before return from function slim_msg_response() in the error handling case. Signed-off-by: Wei Yongjun Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman