Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.1.168 2022-06-08T02:05:14+00:00 2022-06-08T02:05:14+00:00 Chengguang Xu cgxu519@mykernel.net 2022-05-29T15:34:55+00:00 urn:sha1:ec1e8adcbdf661c57c395bca342945f4f815add7 Fix missing resource cleanup (when '(--i) == 0') for error case in pmcraid_register_interrupt_handler(). Link: https://lore.kernel.org/r/20220529153456.4183738-6-cgxu519@mykernel.net Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2022-05-24T03:24:10+00:00 Julia Lawall Julia.Lawall@inria.fr 2022-05-21T11:11:39+00:00 urn:sha1:f6e2694ebb2534f81bdc94501df3db589ba0aea9 Spelling mistake (triple letters) in comment. Detected with the help of Coccinelle. Link: https://lore.kernel.org/r/20220521111145.81697-89-Julia.Lawall@inria.fr Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2022-04-19T02:52:34+00:00 Jiapeng Chong jiapeng.chong@linux.alibaba.com 2022-04-01T03:06:40+00:00 urn:sha1:21a023ce397ba1959d342b1087216655abc2ba49 Fix the following coccicheck warning: ./drivers/scsi/pmcraid.c:4593:2-3: Unneeded semicolon. Link: https://lore.kernel.org/r/20220401030640.28246-1-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2022-03-30T03:32:26+00:00 Christophe JAILLET christophe.jaillet@wanadoo.fr 2022-03-26T12:48:15+00:00 urn:sha1:f16aa285e6185271bc6812a176f7ae3dbd7fe28d The whole passthrough ioctl path looks completely broken. For example it DMA maps the scatterlist and after that copies data to it, which is prohibited by the DMA API contract. Moreover, in pmcraid_alloc_sglist(), the pointer returned by a sgl_alloc_order() call is not recorded anywhere which is pointless. So remove the PMCRAID_PASSTHROUGH_IOCTL ioctl implementation entirely. Should it be needed, we should reimplement it using the proper block layer request mapping helpers. Link: https://lore.kernel.org/r/7f27a70bec3f3dcaf46a29b1c630edd4792e71c0.1648298857.git.christophe.jaillet@wanadoo.fr Suggested-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2021-12-23T04:44:12+00:00 Christoph Hellwig hch@lst.de 2021-12-22T09:22:47+00:00 urn:sha1:657b44d651eb284443d62895d9d47897729ef35a The driver doesn't express DMA addressing limitation under 32-bits anywhere else, so remove the spurious GFP_DMA allocation. Link: https://lore.kernel.org/r/20211222092247.928711-1-hch@lst.de Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2021-11-30T04:02:14+00:00 Bart Van Assche bvanassche@acm.org 2021-11-29T19:46:08+00:00 urn:sha1:b558fa11e4b53027776c451553437aeda4463e4d Fix the following kernel-doc warning: drivers/scsi/pmcraid.c:3317: warning: Excess function parameter 'done' description in 'pmcraid_queuecommand_lck' Link: https://lore.kernel.org/r/20211129194609.3466071-12-bvanassche@acm.org Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2021-10-17T01:45:58+00:00 Bart Van Assche bvanassche@acm.org 2021-10-12T23:35:48+00:00 urn:sha1:646bed7e6f45ef884913458fff6e7f4d69804a23 struct device supports attribute groups directly but does not support struct device_attribute directly. Hence switch to attribute groups. Link: https://lore.kernel.org/r/20211012233558.4066756-37-bvanassche@acm.org Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2021-10-17T01:32:16+00:00 Bart Van Assche bvanassche@acm.org 2021-10-07T20:46:14+00:00 urn:sha1:af049dfd0b105bab32170d1c68826a4cd8424efd The DEF_SCSI_QCMD() macro passes the addresses of the SCSI host lock and also that of the scsi_done function to the queuecommand_lck() function implementations. Remove the 'scsi_done' argument since its address is now a constant and instead call 'scsi_done' directly from inside the queuecommand_lck() functions. Link: https://lore.kernel.org/r/20211007204618.2196847-14-bvanassche@acm.org Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2021-10-17T01:31:40+00:00 Bart Van Assche bvanassche@acm.org 2021-10-07T20:28:55+00:00 urn:sha1:f13cc234bec93959d49b7db9e63f74272b282e5c Conditional statements are faster than indirect calls. Hence call scsi_done() directly. Link: https://lore.kernel.org/r/20211007202923.2174984-61-bvanassche@acm.org Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> 2021-03-19T03:35:55+00:00 Lee Jones lee.jones@linaro.org 2021-03-17T09:12:07+00:00 urn:sha1:a364a147b1dcb3c993c4ff1e7b13fa1643288bfb Fixes the following W=1 kernel build warning(s): drivers/scsi/pmcraid.c:4079: warning: expecting prototype for pmcraid_show_io_adapter_id(). Prototype was for pmcraid_show_adapter_id() instead Link: https://lore.kernel.org/r/20210317091230.2912389-14-lee.jones@linaro.org Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>