kernel/linux.git/drivers/scsi/bfa, branch v3.18.62

bfa: Fix indentation

2017-02-08T08:43:04+00:00

commit b7f4d6343820af5c2dc3979e91d85e71e638cd3d upstream. Signed-off-by: Anil Gurumurthy Tested-by : Sudarasana Kalluru Reviewed-by: Ewan D. Milne Signed-off-by: James Bottomley Signed-off-by: Greg Kroah-Hartman

bfa: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-29T12:38:52+00:00

As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev Acked-by: Anil Gurumurthy Signed-off-by: Christoph Hellwig

bfa: Cleanup bfad_setup_intr() function

2014-07-29T12:38:52+00:00

Signed-off-by: Alexander Gordeev Acked-by: Anil Gurumurthy Signed-off-by: Christoph Hellwig

bfa: Do not call pci_enable_msix() after it failed once

2014-07-29T12:38:52+00:00

Function pci_enable_msix() should not be called in case it threw a negative errno from a previous call. Signed-off-by: Alexander Gordeev Acked-by: Anil Gurumurthy Signed-off-by: Christoph Hellwig

bfa: use ARRAY_SIZE instead of sizeof/sizeof[0]

2014-07-25T21:16:55+00:00

Use macro definition Signed-off-by: Fabian Frederick Acked-by: Anil Gurumurthy Signed-off-by: Christoph Hellwig

bfa: remove useless return variables

2014-07-25T21:16:55+00:00

This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin Acked-by: Sudarsana Kalluru Signed-off-by: Christoph Hellwig

bfa: Fix undefined bit shift on big-endian architectures with 32-bit DMA address

2014-07-25T21:16:54+00:00

bfa_swap_words() shifts its argument (assumed to be 64-bit) by 32 bits each way. In two places the argument type is dma_addr_t, which may be 32-bit, in which case the effect of the bit shift is undefined: drivers/scsi/bfa/bfa_fcpim.c: In function 'bfa_ioim_send_ioreq': drivers/scsi/bfa/bfa_fcpim.c:2497:4: warning: left shift count >= width of type [enabled by default] addr = bfa_sgaddr_le(sg_dma_address(sg)); ^ drivers/scsi/bfa/bfa_fcpim.c:2497:4: warning: right shift count >= width of type [enabled by default] drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: left shift count >= width of type [enabled by default] addr = bfa_sgaddr_le(sg_dma_address(sg)); ^ drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count >= width of type [enabled by default] Avoid this by adding casts to u64 in bfa_swap_words(). Compile-tested only. Signed-off-by: Ben Hutchings Reviewed-by: Martin K. Petersen Acked-by: Anil Gurumurthy Cc: stable@vger.kernel.org Fixes: f16a17507b09 ('[SCSI] bfa: remove all OS wrappers') Signed-off-by: Christoph Hellwig

bfa: Use dma_zalloc_coherent

2014-07-25T21:16:54+00:00

Use the zeroing function instead of dma_alloc_coherent & memset(,0,) Signed-off-by: Joe Perches Acked-by: Anil Gurumurthy Signed-off-by: Christoph Hellwig

bfa: allocate memory with GFP_ATOMIC in spinlock context

2014-05-19T17:12:22+00:00

bfa_fcb_pbc_vport_create() is called only from bfa_fcs_pbc_vport_init(), that is called only from bfad_drv_start() with bfad_lock spinlock held. So the patch replaces GFP_KERNEL with GFP_ATOMIC to avoid sleeping in atomic spinlock context. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Acked-by: Anil Gurumurthy Signed-off-by: Christoph Hellwig

[SCSI] bfa: Replace large udelay() with mdelay()

2014-03-19T22:04:47+00:00

udelay() does not work on some architectures for values above 2000, in particular on ARM: ERROR: "__bad_udelay" [drivers/scsi/bfa/bfa.ko] undefined! Reported-by: Vagrant Cascadian Signed-off-by: Ben Hutchings Signed-off-by: James Bottomley