kernel/linux.git/drivers/s390/net, branch v5.16

s390/qeth: update kerneldoc for qeth_add_hw_header()

2021-10-25T12:58:19+00:00

qeth_add_hw_header() is missing documentation for some of its parameters, fix that up. Reported-by: Heiko Carstens Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: fix kernel doc comments

2021-10-25T12:58:19+00:00

Fix kernel doc comments and remove incorrect kernel doc indicators. Acked-by: Julian Wiedmann Signed-off-by: Heiko Carstens Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: add __printf format attribute to qeth_dbf_longtext

2021-10-25T12:58:19+00:00

Allow the compiler to recognize and check format strings and parameters. As reported with allmodconfig and W=1: drivers/s390/net/qeth_core_main.c: In function ‘qeth_dbf_longtext’: drivers/s390/net/qeth_core_main.c:6190:9: error: function ‘qeth_dbf_longtext’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] 6190 | vsnprintf(dbf_txt_buf, sizeof(dbf_txt_buf), fmt, args); | ^~~~~~~~~ Acked-by: Julian Wiedmann Signed-off-by: Heiko Carstens Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: fix various format strings

2021-10-25T12:58:19+00:00

Various format strings don't match with types of parameters. Fix all of them. Acked-by: Julian Wiedmann Signed-off-by: Heiko Carstens Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: don't keep track of Input Queue count

2021-10-25T12:58:19+00:00

The only actual user of qdio.no_input_queues is qeth_qdio_establish(), and there we already have full awareness of the current Input Queue configuration (1 RX queue, plus potentially 1 TX Completion queue). So avoid this state tracking, and the ambiguity it brings with it. Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: clarify remaining dev_kfree_skb_any() users

2021-10-25T12:58:19+00:00

For none of the users we are under risk of running in HW IRQ context or or with IRQs disabled. Thus we always end up in consume_skb(). But the two occurences in the RX path should really report the dropped packet to dropmon, so have them use kfree_skb() instead. That's also consistent with what napi_free_frags() does internally. Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: move qdio's QAOB cache into qeth

2021-10-25T12:58:19+00:00

qdio.ko no longer needs to care about how the QAOBs are allocated, from its perspective they are merely another parameter to do_QDIO(). So for a start, shift the cache into the only qdio driver that uses QAOBs (ie. qeth). Here there's further opportunity to optimize its usage in the future - eg. make it per-{device, TX queue}, or only compile it when the driver is built with CQ/QAOB support. Signed-off-by: Julian Wiedmann Reviewed-by: Benjamin Block Signed-off-by: David S. Miller

s390/qeth: remove .do_ioctl() callback from driver discipline

2021-10-25T12:58:19+00:00

With commit 18787eeebd71 ("qeth: use ndo_siocdevprivate") this callback is now actually used to handle transport mode-specific _private_ ioctls. We only have such ioctls for L3 devices. So wire up a L3-specific .ndo_siocdevprivate() callback that handles those ioctls, and defers to the core qeth_siocdevprivate() for all other private ioctls. This takes the discipline one step closer to its original purpose of providing an internal extension for the qeth_core_ccwgroup_driver. Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller

s390/qeth: improve trace entries for MAC address (un)registration

2021-10-25T12:58:19+00:00

Add the failed MAC address into the trace message. Also fix up one format string to use %x instead of %u for the CARD_DEVID. Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter Signed-off-by: David S. Miller

net: s390: constify and use eth_hw_addr_set()

2021-10-22T17:16:11+00:00

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all the writes to it got through appropriate helpers. Make sure local references to netdev->dev_addr are constant. Acked-by: Julian Wiedmann Signed-off-by: Jakub Kicinski