kernel/linux.git/drivers/rtc/rtc-s35390a.c, branch linux-7.1.y

rtc: s35390a: implement nvmem support

2026-01-30T23:17:16+00:00

This RTC has one "free" register which can be used to store arbitrary data. Expose it as a nvmem resource in Linux. Signed-off-by: Lorenz Brun Link: https://patch.msgid.link/20251223125728.346073-1-lorenz@monogon.tech Signed-off-by: Alexandre Belloni

rtc: s35390a: use u8 instead of char for register buffer

2025-12-08T21:23:24+00:00

The register buffer in s35390a_get_reg() was previously defined as `char *buf`. This is not ideal since register data represents raw binary values rather than textual data. Switch the type to `u8 *buf` to better reflect its intended usage and to avoid potential issues with sign extension when handling register values on platforms where `char` is signed by default. This change improves type safety and makes the code consistent with other RTC drivers that operate on raw register data. Signed-off-by: Nick Huang Link: https://patch.msgid.link/20250920174224.108795-1-sef1548@gmail.com Signed-off-by: Alexandre Belloni

rtc: s35390a: drop needless struct s35390a::rtc member

2025-03-05T22:08:01+00:00

The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-12-d4689a71668c@linaro.org Signed-off-by: Alexandre Belloni

rtc: s35390a: Drop vendorless compatible string from match table

2024-09-11T22:15:49+00:00

There's no need to list "s35390a" in the DT match table. The I2C core will strip any vendor prefix and match against the i2c_device_id table which has an "s35390a" entry. Signed-off-by: Rob Herring (Arm) Link: https://lore.kernel.org/r/20240826191321.1410668-1-robh@kernel.org Signed-off-by: Alexandre Belloni

rtc: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-07-06T22:40:29+00:00

These drivers don't use the driver_data member of struct i2c_device_id, so don't explicitly initialize this member. This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's also a nice cleanup on its own. While add it, also remove a comma after the sentinel entry in rtc-hym8563. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20240515194336.58342-2-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni

rtc: Switch i2c drivers back to use .probe()

2023-06-06T21:29:37+00:00

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230505121136.1185653-1-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni

rtc: s35390a: Remove the unneeded result variable

2022-11-15T20:01:51+00:00

Return the value s35390a_set_reg() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen Link: https://lore.kernel.org/r/20220905090119.335121-1-ye.xingchen@zte.com.cn Signed-off-by: Alexandre Belloni

rtc: use simple i2c probe

2022-06-24T19:24:02+00:00

All these drivers have an i2c probe function which doesn't use the "struct i2c_device_id *id" parameter, so they can trivially be converted to the "probe_new" style of probe with a single argument. This change was done using the following Coccinelle script, and fixed up for whitespace changes: @ rule1 @ identifier fn; identifier client, id; @@ - static int fn(struct i2c_client *client, const struct i2c_device_id *id) + static int fn(struct i2c_client *client) { ...when != id } @ rule2 depends on rule1 @ identifier rule1.fn; identifier driver; @@ struct i2c_driver driver = { - .probe + .probe_new = ( fn | - &fn + fn ) , }; Signed-off-by: Stephen Kitt Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220610162346.4134094-1-steve@sk2.org

rtc: s35390a: let the core handle the alarm resolution

2021-11-09T23:45:57+00:00

Tell the RTC core UIE are not supported because the resolution of the alarm is a minute. Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20211107225458.111068-2-alexandre.belloni@bootlin.com

rtc: s35390a: quiet maybe-unused variable warning

2021-02-05T23:58:25+00:00

When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210202112219.3610853-21-alexandre.belloni@bootlin.com