kernel/linux.git/drivers/rtc/rtc-r9701.c, branch v6.18.21Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.18.212020-11-19T11:50:12+00:00rtc: rework rtc_register_device() resource management2020-11-19T11:50:12+00:00Bartosz Golaszewskibgolaszewski@baylibre.com2020-11-09T16:34:08+00:00urn:sha1:fdcfd854333be5b30377dc5daa9cd0fa1643a979
rtc_register_device() is a managed interface but it doesn't use devres
by itself - instead it marks an rtc_device as "registered" and the devres
callback for devm_rtc_allocate_device() takes care of resource release.
This doesn't correspond with the design behind devres where managed
structures should not be aware of being managed. The correct solution
here is to register a separate devres callback for unregistering the
device.
While at it: rename rtc_register_device() to devm_rtc_register_device()
and add it to the list of managed interfaces in devres.rst. This way we
can avoid any potential confusion of driver developers who may expect
there to exist a corresponding unregister function.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl
rtc: r9701: set range2020-10-19T20:48:55+00:00Alexandre Bellonialexandre.belloni@bootlin.com2020-10-15T19:11:35+00:00urn:sha1:35331b506f6c67a0b4042fac1ae2785cef9ac8c3
Set range and remove the set_time check. This is a classic BCD RTC.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-6-alexandre.belloni@bootlin.com
rtc: r9701: convert to devm_rtc_allocate_device2020-10-19T20:48:55+00:00Alexandre Bellonialexandre.belloni@bootlin.com2020-10-15T19:11:34+00:00urn:sha1:dfe13cf2ae5a7cdb131e61a8aae4fb27cd379bd4
This allows further improvement of the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-5-alexandre.belloni@bootlin.com
rtc: r9701: stop setting RWKCNT2020-10-19T20:48:55+00:00Alexandre Bellonialexandre.belloni@bootlin.com2020-10-15T19:11:33+00:00urn:sha1:8b34134907e7d70b8b51fa56ecd4f8c50c46692c
tm_wday is never checked for validity and it is not read back in
r9701_get_datetime. Avoid setting it to stop tripping static checkers:
drivers/rtc/rtc-r9701.c:109 r9701_set_datetime()
error: undefined (user controlled) shift '1 << dt->tm_wday'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-4-alexandre.belloni@bootlin.com
rtc: r9701: remove useless memset2020-10-19T20:48:55+00:00Alexandre Bellonialexandre.belloni@bootlin.com2020-10-15T19:11:32+00:00urn:sha1:2a8f3380c9e50a36b99a92febfd78f7c7afd29b0
The RTC core already sets to zero the struct rtc_tie it passes to the
driver, avoid doing it a second time.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-3-alexandre.belloni@bootlin.com
rtc: r9701: stop setting a default time2020-10-19T20:48:55+00:00Alexandre Bellonialexandre.belloni@bootlin.com2020-10-15T19:11:31+00:00urn:sha1:7390bec4ed5d510d1a637257ff75e9ab49030411
It doesn't make sense to set the RTC to a default value at probe time. Let
the core handle invalid date and time.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-2-alexandre.belloni@bootlin.com
rtc: r9701: remove leftover comment2020-10-19T20:48:55+00:00Alexandre Bellonialexandre.belloni@bootlin.com2020-10-15T19:11:30+00:00urn:sha1:92c6dcfbd1eb803d4669c82b3d8a0fcbb803e3f9
Commit 22652ba72453 ("rtc: stop validating rtc_time in .read_time") removed
the code but not the associated comment.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-1-alexandre.belloni@bootlin.com
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 5002019-06-19T15:09:55+00:00Thomas Gleixnertglx@linutronix.de2019-06-04T08:11:33+00:00urn:sha1:d2912cb15bdda8ba4a5dd73396ad62641af2f520
Based on 2 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundation
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license version 2 as
published by the free software foundation #
extracted by the scancode license scanner the SPDX license identifier
GPL-2.0-only
has been chosen to replace the boilerplate/reference in 4122 file(s).
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Enrico Weigelt <info@metux.net>
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Allison Randal <allison@lohutok.net>
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
rtc: stop validating rtc_time in .read_time2018-03-02T09:09:58+00:00Alexandre Bellonialexandre.belloni@bootlin.com2018-02-19T15:23:56+00:00urn:sha1:22652ba72453d35c8a637d5c0f06b3dc29ff9eb0
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: r9701: Remove r9701_remove function2017-11-29T21:13:30+00:00Nobuhiro Iwamatsuiwamatsu@nigauri.org2017-11-18T02:03:10+00:00urn:sha1:5c6e5eca79e8a5a89a7ae98b30ba6d71e367d899
r9701_remove function is now empty, remove it.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>