kernel/linux.git/drivers/rtc/rtc-ds2404.c, branch v6.19.11

rtc: ds2404: drop needless struct ds2404::rtc member

2025-03-05T22:08:00+00:00

The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-4-d4689a71668c@linaro.org Signed-off-by: Alexandre Belloni

rtc: ds2404: Convert to GPIO descriptors

2023-08-16T22:55:56+00:00

This converts the DS2404 to use GPIO descriptors instead of hard-coded global GPIO numbers. The platform data can be deleted because there are no in-tree users and it only contained GPIO numbers which are now passed using descriptor tables (or device tree or ACPI). The driver was rewritten to use a state container for the device driver state (struct ds2404 *chip) and pass that around instead of using a global singleton storage for the GPIO handles. When declaring GPIO descriptor tables or other hardware descriptions for the RTC driver, implementers should take care to flag the RESET line as active low, such as by using the GPIOD_ACTIVE_LOW flag in the descriptor table. Signed-off-by: Linus Walleij Link: https://lore.kernel.org/r/20230807-descriptors-rtc-v1-1-ce0f9187576e@linaro.org Signed-off-by: Alexandre Belloni

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres by itself - instead it marks an rtc_device as "registered" and the devres callback for devm_rtc_allocate_device() takes care of resource release. This doesn't correspond with the design behind devres where managed structures should not be aware of being managed. The correct solution here is to register a separate devres callback for unregistering the device. While at it: rename rtc_register_device() to devm_rtc_register_device() and add it to the list of managed interfaces in devres.rst. This way we can avoid any potential confusion of driver developers who may expect there to exist a corresponding unregister function. Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: ds2404: use hw endiannes variable

2019-05-23T15:42:25+00:00

Converting from hardware to host endiannes was done using reassignment to the same variable which makes sparse unhappy as it can not verify the endiannes handling properly. To allow sparse to verify endiannes handling an explicit __le32 is introduced. Note that this patch does not change the generated binary (x86_64 and ppc64 binary diff). Signed-off-by: Nicholas Mc Guire Signed-off-by: Alexandre Belloni

rtc: ds2404: simplify .probe and remove .remove

2019-04-19T20:37:17+00:00

Use devm_add_action_or_reset to simplify .probe and remove .remove Signed-off-by: Alexandre Belloni

rtc: ds2404: remove ds2404_chip_ops

2019-04-19T20:37:17+00:00

There is only one ds2404_chip_ops struct that is implemented, remove the unnecessary indirection. Signed-off-by: Alexandre Belloni

rtc: ds2404: convert to SPDX identifier

2019-04-19T20:37:17+00:00

Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: Alexandre Belloni

rtc: ds2404: use .set_time

2019-04-19T20:37:17+00:00

Use .set_time instead of the deprecated .set_mmss. Signed-off-by: Alexandre Belloni

rtc: ds2404: switch to rtc_time64_to_tm

2019-04-19T20:37:16+00:00

Call the 64bit version of rtc_time_to_tm now that the range is enforced by the core. Signed-off-by: Alexandre Belloni

rtc: ds2404: set range

2019-04-19T20:37:16+00:00

The real-time clock is a 5-byte binary counter. It is incremented 256 times per second. The least significant byte is a count of fractional seconds. The upper four bytes are a count of seconds. The realtime clock can accumulate 136 years of seconds before rolling over. Signed-off-by: Alexandre Belloni