kernel/linux.git/drivers/rtc/rtc-ds1672.c, branch v6.19.11

rtc: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-07-06T22:40:29+00:00

These drivers don't use the driver_data member of struct i2c_device_id, so don't explicitly initialize this member. This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's also a nice cleanup on its own. While add it, also remove a comma after the sentinel entry in rtc-hym8563. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20240515194336.58342-2-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni

rtc: Switch i2c drivers back to use .probe()

2023-06-06T21:29:37+00:00

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230505121136.1185653-1-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni

rtc: use simple i2c probe

2022-06-24T19:24:02+00:00

All these drivers have an i2c probe function which doesn't use the "struct i2c_device_id *id" parameter, so they can trivially be converted to the "probe_new" style of probe with a single argument. This change was done using the following Coccinelle script, and fixed up for whitespace changes: @ rule1 @ identifier fn; identifier client, id; @@ - static int fn(struct i2c_client *client, const struct i2c_device_id *id) + static int fn(struct i2c_client *client) { ...when != id } @ rule2 depends on rule1 @ identifier rule1.fn; identifier driver; @@ struct i2c_driver driver = { - .probe + .probe_new = ( fn | - &fn + fn ) , }; Signed-off-by: Stephen Kitt Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220610162346.4134094-1-steve@sk2.org

rtc: ds1672: quiet maybe-unused variable warning

2021-02-05T23:58:24+00:00

When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210202112219.3610853-7-alexandre.belloni@bootlin.com

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres by itself - instead it marks an rtc_device as "registered" and the devres callback for devm_rtc_allocate_device() takes care of resource release. This doesn't correspond with the design behind devres where managed structures should not be aware of being managed. The correct solution here is to register a separate devres callback for unregistering the device. While at it: rename rtc_register_device() to devm_rtc_register_device() and add it to the list of managed interfaces in devres.rst. This way we can avoid any potential confusion of driver developers who may expect there to exist a corresponding unregister function. Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: ds1672: remove unnecessary check

2019-08-21T07:57:23+00:00

The rtc pointer is already checked earlier, it is not necessary to check it again. Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190818215232.17320-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni

rtc: ds1672: switch debug message to %ptR

2019-04-08T12:35:46+00:00

Use %ptR to simplify debug message. Signed-off-by: Alexandre Belloni

rtc: ds1672: convert to SPDX identifier

2019-04-08T12:35:40+00:00

Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: Alexandre Belloni

rtc: ds1672: use .set_time

2019-04-08T12:35:38+00:00

Use .set_time instead of the deprecated .set_mmss. Signed-off-by: Alexandre Belloni

rtc: ds1672: use rtc_time64_to_tm

2019-04-08T12:35:33+00:00

Use the 64bit version of rtc_time_to_tm.rtc_time_to_tm. Signed-off-by: Alexandre Belloni