kernel/linux.git/drivers/rtc/rtc-da9052.c, branch v6.12.80

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres by itself - instead it marks an rtc_device as "registered" and the devres callback for devm_rtc_allocate_device() takes care of resource release. This doesn't correspond with the design behind devres where managed structures should not be aware of being managed. The correct solution here is to register a separate devres callback for unregistering the device. While at it: rename rtc_register_device() to devm_rtc_register_device() and add it to the list of managed interfaces in devres.rst. This way we can avoid any potential confusion of driver developers who may expect there to exist a corresponding unregister function. Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: da9052: switch to rtc_time64_to_tm/rtc_tm_to_time64

2020-04-01T10:33:43+00:00

Call the 64bit versions of rtc_tm time conversion. Acked-by: Adam Thomson Link: https://lore.kernel.org/r/20200306073548.57579-3-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni

rtc: da9052: set range

2020-04-01T10:33:43+00:00

The da9052 is an rtc valid from 2000 to 2063 (max year is 63). Acked-by: Adam Thomson Link: https://lore.kernel.org/r/20200306073548.57579-2-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni

rtc: da9052: convert to devm_rtc_allocate_device

2020-04-01T10:33:34+00:00

This allows further improvement of the driver. Acked-by: Adam Thomson Link: https://lore.kernel.org/r/20200329224240.776568-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30T18:26:32+00:00

Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version extracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-later has been chosen to replace the boilerplate/reference in 3029 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de Signed-off-by: Greg Kroah-Hartman

rtc: diasemi: stop validating rtc_time in .read_time

2018-03-02T09:11:02+00:00

The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it before returning from the callback. Acked-by: Steve Twiss Signed-off-by: Alexandre Belloni

rtc: explicitly set tm_sec = 0 for drivers with minute accurancy

2016-07-19T16:15:21+00:00

Since all time members of the alarm data is initialized to -1 the drivers are responsible to set the tm_sec member to 0. Fixes: d68778b80dd7 ("rtc: initialize output parameter for read alarm to "uninitialized"") Signed-off-by: Uwe Kleine-König Signed-off-by: Alexandre Belloni

rtc: da9053: fix access ordering error during RTC interrupt at system power on

2016-05-20T10:33:51+00:00

This fix alters the ordering of the IRQ and device registrations in the RTC driver probe function. This change will apply to the RTC driver that supports both DA9052 and DA9053 PMICs. A problem could occur with the existing RTC driver if: A system is started from a cold boot using the PMIC RTC IRQ to initiate a power on operation. For instance, if an RTC alarm is used to start a platform from power off. The existing driver IRQ is requested before the device has been properly registered. i.e. ret = da9052_request_irq() comes before rtc->rtc = devm_rtc_device_register(); In this case, an interrupt exists before the device has been registered and the IRQ handler can be called immediately: this can happen be before the memory for rtc->rtc has been allocated. The IRQ handler da9052_rtc_irq() contains the function call: rtc_update_irq(rtc->rtc, 1, RTC_IRQF | RTC_AF); which in turn tries to access the unavailable rtc->rtc. The fix is to reorder the functions inside the RTC probe. The IRQ is requested after the RTC device resource has been registered so that da9052_request_irq() is the last thing to happen. Signed-off-by: Steve Twiss Signed-off-by: Alexandre Belloni

drivers/rtc/rtc-da9052.c: register ability of alarm to wake device from suspend

2015-04-17T13:04:00+00:00

Signed-off-by: Adam Ward Tested-by: Adam Ward Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-da9052.c: add constraints to set valid year

2015-04-17T13:04:00+00:00

Signed-off-by: Adam Ward Tested-by: Adam Ward Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds