Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.1.168 2025-12-06T21:12:34+00:00 2025-12-06T21:12:34+00:00 Haotian Zhang vulab@iscas.ac.cn 2025-10-28T17:28:28+00:00 urn:sha1:c8ba621ffdf69b645db5768d88b3d03e6406a5cf [ Upstream commit 636f4618b1cd96f6b5a2b8c7c4f665c8533ecf13 ] In the commit referenced by the Fixes tag, devm_gpiod_get_optional() was replaced by manual GPIO management, relying on the regulator core to release the GPIO descriptor. However, this approach does not account for the error path: when regulator registration fails, the core never takes over the GPIO, resulting in a resource leak. Add gpiod_put() before returning on regulator registration failure. Fixes: 5e6f3ae5c13b ("regulator: fixed: Let core handle GPIO descriptor") Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn> Link: https://patch.msgid.link/20251028172828.625-1-vulab@iscas.ac.cn Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> 2023-04-06T10:10:46+00:00 Christophe JAILLET christophe.jaillet@wanadoo.fr 2023-03-26T08:29:33+00:00 urn:sha1:f70328a0bfb2e3dea05682638c9c0e0d7b8ce2f2 [ Upstream commit 02bcba0b9f9da706d5bd1e8cbeb83493863e17b5 ] devm_clk_get() can return -EPROBE_DEFER. So it is better to return the error code from devm_clk_get(), instead of a hard coded -ENOENT. This gives more opportunities to successfully probe the driver. Fixes: 8959e5324485 ("regulator: fixed: add possibility to enable by clock") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/18459fae3d017a66313699c7c8456b28158b2dd0.1679819354.git.christophe.jaillet@wanadoo.fr Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> 2022-04-04T07:48:30+00:00 Mark Brown broonie@kernel.org 2022-03-24T20:18:54+00:00 urn:sha1:6c315afe65d05dc6eebf2d6b73a191990aada218 OOMs are very verbose, we don't need to print an additional error message when we fail to allocate. Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20220324201854.3107077-1-broonie@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org> 2021-07-22T11:40:12+00:00 Chris Morgan macromorgan@hotmail.com 2021-07-21T16:57:16+00:00 urn:sha1:d0f95e6496a974a890df5eda65ffaee66ab0dc73 Instead of returning error directly, use dev_err_probe. This avoids messages in the dmesg log for devices which will be probed again later. Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Link: https://lore.kernel.org/r/20210721165716.19915-1-macroalpha82@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org> 2021-06-23T15:56:31+00:00 Mark Brown broonie@kernel.org 2021-06-23T15:56:31+00:00 urn:sha1:7fb593cbd88cf4df01c096d4dc320f027dfa2560 2021-06-16T14:41:20+00:00 Rouven Czerwinski r.czerwinski@pengutronix.de 2021-06-16T12:53:31+00:00 urn:sha1:7740ab84c13e32002742106afd443a4ca7fe3918 Instead of returning the the PTR_ERR directly, use dev_err_probe which will also correctly set the deferred probe reason in /sys/kernel/debug/deferred_devices, making it easier to debug missing devices on the system. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de> Link: https://lore.kernel.org/r/20210616125331.153414-1-r.czerwinski@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org> 2021-05-20T16:57:23+00:00 Axel Lin axel.lin@ingics.com 2021-05-20T11:18:11+00:00 urn:sha1:855bfff9d623e7aff6556bfb6831d324dec8d96a dev_pm_genpd_set_performance_state() may fail, so had better to check it's return value before decreasing priv->enable_counter. Fixes: bf3a28cf4241 ("regulator: fixed: support using power domain for enable/disable") Signed-off-by: Axel Lin <axel.lin@ingics.com> Link: https://lore.kernel.org/r/20210520111811.1806293-1-axel.lin@ingics.com Signed-off-by: Mark Brown <broonie@kernel.org> 2020-10-26T20:46:26+00:00 Dmitry Baryshkov dmitry.baryshkov@linaro.org 2020-10-23T13:19:22+00:00 urn:sha1:bf3a28cf42412c0a85631da94f198048bb37a8e5 Adds possibility to choose the compatible "fixed-regulator-domain" for regulators which use power domain for enabling/disabling corresponding regulator. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20201023131925.334864-3-dmitry.baryshkov@linaro.org Signed-off-by: Mark Brown <broonie@kernel.org> 2020-09-14T13:24:37+00:00 Rikard Falkeborn rikard.falkeborn@gmail.com 2020-09-13T08:41:11+00:00 urn:sha1:96ee75ffd4f63a3d5f9d6a3ea592b2c0ee97acb0 The only usage of fixed_voltage_ops and fixed_voltage_clkenabled_ops is to assign their address the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Link: https://lore.kernel.org/r/20200913084114.8851-3-rikard.falkeborn@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org> 2020-08-21T16:28:11+00:00 Jisheng Zhang Jisheng.Zhang@synaptics.com 2020-08-21T03:14:03+00:00 urn:sha1:0f037255008386f4ac15a201678e8e4565cd91a3 Fix below warnings when CONFIG_OF=n: drivers/regulator/fixed.c:48:36: warning: ‘fixed_clkenable_data’ defined but not used [-Wunused-const-variable=] 48 | static const struct fixed_dev_type fixed_clkenable_data = { | ^~~~~~~~~~~~~~~~~~~~ drivers/regulator/fixed.c:44:36: warning: ‘fixed_voltage_data’ defined but not used [-Wunused-const-variable=] 44 | static const struct fixed_dev_type fixed_voltage_data = { | ^~~~~~~~~~~~~~~~~~ Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> Link: https://lore.kernel.org/r/20200821111403.3e8b58a3@xhacker.debian Signed-off-by: Mark Brown <broonie@kernel.org>