kernel/linux.git/drivers/platform/x86/hp, branch v6.6

platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning

2023-10-06T13:09:40+00:00

As described in the added code comment, a reference to .exit.text is ok for drivers registered via module_platform_driver_probe(). Make this explicit to prevent a section mismatch warning: WARNING: modpost: drivers/platform/x86/hp/hp-wmi: section mismatch in reference: hp_wmi_driver+0x8 (section: .data) -> hp_wmi_bios_remove (section: .exit.text) Fixes: c165b80cfecc ("hp-wmi: fix handling of platform device") Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231004111624.2667753-1-u.kleine-koenig@pengutronix.de Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Fix reference leak

2023-10-04T09:52:30+00:00

If a duplicate attribute is found using kset_find_obj(), a reference to that attribute is returned which needs to be disposed accordingly using kobject_put(). Use kobject_put() to dispose the duplicate attribute in such a case. As a side note, a very similar bug was fixed in commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak"), so it seems that the bug was copied from that driver. Compile-tested only. Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg") Suggested-by: Ilpo Järvinen Reviewed-by: Ilpo Järvinen Signed-off-by: Armin Wolf Reviewed-by: Jorge Lopez Link: https://lore.kernel.org/r/20230925142819.74525-3-W_Armin@gmx.de Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Update steps order list elements are evaluated

2023-08-21T16:56:18+00:00

Update steps how order list elements data and elements size are evaluated. Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230821144205.13529-1-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Use kmemdup() to replace kmalloc + memcpy

2023-08-07T11:36:20+00:00

There are some warnings reported by coccinelle: ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:317:35-42: WARNING opportunity for kmemdup ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:270:40-47: WARNING opportunity for kmemdup ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:233:36-43: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation. Signed-off-by: Li Zetao Reviewed-by: Jorge Lopez Link: https://lore.kernel.org/r/20230803032027.3044851-1-lizetao1@huawei.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Remove duplicate use of variable in inner loop

2023-08-07T11:35:32+00:00

Replace use of same variable in inner loop. Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230731203141.30044-9-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Change how password encoding size is evaluated

2023-08-07T11:35:30+00:00

Update steps how password encoding size is evaluated Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230731203141.30044-8-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Change how enum possible values size is evaluated

2023-08-07T11:35:28+00:00

Updates steps how enum possible values size is evaluated Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230731203141.30044-7-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Change how order list size is evaluated

2023-08-07T11:35:23+00:00

Update steps how order list size is evaluated Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230731203141.30044-6-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Change how prerequisites size is evaluated

2023-08-07T11:34:46+00:00

Update steps taken to evaluate prerequisites size value Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230731203141.30044-5-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

platform/x86: hp-bioscfg: Replace the word HACK from source code

2023-08-07T11:34:42+00:00

Replace the word 'HACK' with 'step' from source code Signed-off-by: Jorge Lopez Link: https://lore.kernel.org/r/20230731203141.30044-4-jorge.lopez2@hp.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede