Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.80 2022-03-22T16:24:48+00:00 2022-03-22T16:24:48+00:00 Bjorn Helgaas bhelgaas@google.com 2022-03-13T19:29:33+00:00 urn:sha1:6a8fcf7d47a0679a0fe4239c783224ceb559e661 Remove variables and assignments that are never used. Found by Krzysztof using cppcheck, e.g.: $ cppcheck --enable=all --force unreadVariable drivers/pci/hotplug/ibmphp_res.c:1958 Variable 'bus_sec' is assigned a value that is never used. Reported-by: Krzysztof Wilczyński <kw@linux.com> Link: https://lore.kernel.org/r/20220313192933.434746-6-helgaas@kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> 2020-08-23T22:36:59+00:00 Gustavo A. R. Silva gustavoars@kernel.org 2020-08-23T22:36:59+00:00 urn:sha1:df561f6688fef775baa341a0f5d960becd248b11 Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> 2019-08-08T20:13:34+00:00 Gustavo A. R. Silva gustavo@embeddedor.com 2019-08-02T01:22:48+00:00 urn:sha1:5a2e340690f2908371eb9c1b4cfb82ba0b235b51 Mark switch cases where we are expecting to fall through. This fixes the following warning (Building: allmodconfig i386): drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’: drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=] function = 0x8; ~~~~~~~~~^~~~~ drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here case PCI_HEADER_TYPE_MULTIBRIDGE: ^~~~ Link: https://lore.kernel.org/r/20190802012248.GA22622@embeddedor Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> 2018-02-01T17:40:07+00:00 Bjorn Helgaas bhelgaas@google.com 2018-02-01T17:40:07+00:00 urn:sha1:ab8c609356fbe8dbcd44df11e884ce8cddf3739e * pci/spdx: PCI: Add SPDX GPL-2.0+ to replace implicit GPL v2 or later statement PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate PCI: Add SPDX GPL-2.0 to replace COPYING boilerplate PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate PCI: Add SPDX GPL-2.0 when no license was specified 2018-01-28T21:49:06+00:00 Bjorn Helgaas bhelgaas@google.com 2018-01-26T20:22:04+00:00 urn:sha1:736759ef59d86a7bcefb1cdb629abecafc645a46 Add SPDX GPL-2.0+ to all PCI files that specified the GPL and allowed either GPL version 2 or any later version. Remove the boilerplate GPL version 2 or later language, relying on the assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") that the SPDX identifier may be used instead of the full boilerplate text. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2018-01-17T14:41:41+00:00 Markus Elfring elfring@users.sourceforge.net 2017-12-29T11:15:16+00:00 urn:sha1:c7abb2352c298e8ac2ccfd843f036ae5244d6f35 Per ebfdc40969f2 ("checkpatch: attempt to find unnecessary 'out of memory' messages"), when a memory allocation fails, the memory subsystem emits generic "out of memory" messages (see slab_out_of_memory() for some of this logging). Therefore, additional error messages in the caller don't add much value. Remove messages that merely report "out of memory". This preserves some messages that report additional information, e.g., allocation failures that mean we drop hotplug events. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> [bhelgaas: changelog, squash patches, make similar changes to acpiphp, cpqphp, ibmphp, keep warning when dropping hotplug event] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> 2016-01-20T17:48:25+00:00 Bjorn Helgaas bhelgaas@google.com 2016-01-20T17:48:25+00:00 urn:sha1:9662e32c810ad3e6ce49832d5f585a54f8fbdbdb * pci/trivial: PCI: shpchp: Constify hpc_ops structure PCI: Use kobj_to_dev() instead of open-coding it PCI: Use to_pci_dev() instead of open-coding it PCI: Fix all whitespace issues PCI/MSI: Fix typos in <linux/msi.h> 2016-01-10T22:10:29+00:00 Geliang Tang geliangtang@163.com 2015-12-12T13:36:57+00:00 urn:sha1:2ac83cccabbc8d264c20ce11931d60e0e6ea3f53 Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang <geliangtang@163.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> 2016-01-08T16:35:24+00:00 Bogicevic Sasa brutallesale@gmail.com 2015-12-27T21:21:11+00:00 urn:sha1:ff3ce480e8b59fbc0f459476fe1b5451464592a5 Fix all whitespace issues (missing or needed whitespace) in all files in drivers/pci. Code is compiled with allyesconfig before and after code changes and objects are recorded and checked with objdiff and they are not changed after this commit. Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> 2014-11-11T04:08:07+00:00 Quentin Lambert lambert.quentin@gmail.com 2014-11-06T16:45:55+00:00 urn:sha1:754834b9caae8d1380f66a5f0337547e9361094d Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>