kernel/linux.git/drivers/ntb/test/ntb_tool.c, branch v6.12.80

NTB: ntb_tool: Switch to memdup_user_nul() helper

2023-08-18T13:50:06+00:00

Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Ruan Jinjie Reviewed-by: Dave Jiang Reviewed-by: Dan Carpenter Reviewed-by: Serge Semin Signed-off-by: Jon Mason

ntb: Remove error checking for debugfs_create_dir()

2023-08-18T13:50:06+00:00

It is expected that most callers should _ignore_ the errors return by debugfs_create_dir() in tool_setup_dbgfs() Signed-off-by: Wang Ming Reviewed-by: Dave Jiang Reviewed-by: Dan Carpenter Reviewed-by: Serge Semin Signed-off-by: Jon Mason

NTB: ntb_tool: Add check for devm_kcalloc

2023-07-08T14:51:56+00:00

As the devm_kcalloc may return NULL pointer, it should be better to add check for the return value, as same as the others. Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support") Signed-off-by: Jiasheng Jiang Reviewed-by: Serge Semin Reviewed-by: Dave Jiang Signed-off-by: Jon Mason

NTB: ntb_tool: uninitialized heap data in tool_fn_write()

2022-08-09T15:54:41+00:00

The call to: ret = simple_write_to_buffer(buf, size, offp, ubuf, size); will return success if it is able to write even one byte to "buf". The value of "*offp" controls which byte. This could result in reading uninitialized data when we do the sscanf() on the next line. This code is not really desigined to handle partial writes where *offp is non-zero and the "buf" is preserved and re-used between writes. Just ban partial writes and replace the simple_write_to_buffer() with copy_from_user(). Fixes: 578b881ba9c4 ("NTB: Add tool test client") Signed-off-by: Dan Carpenter Signed-off-by: Jon Mason

NTB: ntb_tool: reading the link file should not end in a NULL byte

2020-06-06T00:02:08+00:00

When running ntb_test this warning is issued: ./ntb_test.sh: line 200: warning: command substitution: ignored null byte in input This is caused by the kernel returning one more byte than is necessary when reading the link file. Reduce the number of bytes read back to 2 as it was before the commit that regressed this. Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support") Signed-off-by: Logan Gunthorpe Acked-by: Allen Hubbe Tested-by: Alexander Fomichev Signed-off-by: Jon Mason

ntb_tool: pass correct struct device to dma_alloc_coherent

2020-06-06T00:02:08+00:00

Currently, ntb->dev is passed to dma_alloc_coherent and dma_free_coherent calls. The returned dma_addr_t is the CPU physical address. This works fine as long as IOMMU is disabled. But when IOMMU is enabled, we need to make sure that IOVA is returned for dma_addr_t. So the correct way to achieve this is by changing the first parameter of dma_alloc_coherent() as ntb->pdev->dev instead. Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support") Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath Signed-off-by: Jon Mason

ntb_tool: Fix printk format

2020-03-13T14:03:49+00:00

The correct printk format is %pa or %pap, but not %pa[p]. Fixes: 7f46c8b3a5523 ("NTB: ntb_tool: Add full multi-port NTB API support") Signed-off-by: Helge Deller Signed-off-by: Jon Mason

NTB: ntb_tool: fix memory leak on 'buf' on error exit path

2018-01-29T03:17:24+00:00

Currently there is a memory leak on buf when the call to ntb_mw_get_align fails. Add an exit err label and jump to this so that kfree on buf frees the memory. Detected by CoverityScan, CID#1464286 ("Resource leak") Fixes: d637628ce00c ("NTB: ntb_tool: Add full multi-port NTB API support") Signed-off-by: Colin Ian King Acked-by: Serge Semin Signed-off-by: Jon Mason

NTB: ntb_tool: Add full multi-port NTB API support

2018-01-29T03:17:24+00:00

Former NTB Debugging tool driver supported only the limited functionality of the recently updated NTB API, which is now available to work with the truly NTB multi-port devices and devices, which got NTB Message registers instead of Scratchpads. This patch fully rewrites the driver so one would fully expose all the new NTB API interfaces. Particularly it concerns the Message registers, peer ports API, NTB link settings. Additional cleanups are also added here. Signed-off-by: Serge Semin Signed-off-by: Jon Mason

ntb: remove unneeded DRIVER_LICENSE #defines

2018-01-29T03:17:23+00:00

There is no need to #define the license of the driver, just put it in the MODULE_LICENSE() line directly as a text string. This allows tools that check that the module license matches the source code license to work properly, as there is no need to unwind the unneeded dereference, especially when the string is defined just a few lines above the usage of it. Reported-and-reviewed-by: Philippe Ombredanne Signed-off-by: Greg Kroah-Hartman Cc: Dave Jiang Cc: Allen Hubbe Cc: Gary R Hook Cc: Serge Semin Signed-off-by: Jon Mason