kernel/linux.git/drivers/net/phy/fixed_phy.c, branch v6.19.11Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.19.112025-11-21T02:18:54+00:00net: phy: fixed_phy: remove not needed initialization of phy_device members2025-11-21T02:18:54+00:00Heiner Kallweithkallweit1@gmail.com2025-11-19T06:55:47+00:00urn:sha1:d99b408ed8e5f7c070274f4d6c73023b2aae22b3
All these members are populated by the phylib state machine once the
PHY has been started, based on the fixed autoneg results.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/bc666a53-5469-4e9c-85a1-dd285aadfe4f@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: fix missing initialization of fixed phy link2025-11-21T02:16:59+00:00Heiner Kallweithkallweit1@gmail.com2025-11-19T07:05:45+00:00urn:sha1:bd048f8ce6ce8d5e16415fd6f7506e916cb3d418
Original change remove the link initialization from the passed struct
fixed_phy_status, but @status is also passed to __fixed_phy_add(),
where it is saved. Make sure that copy also has link set to 1.
Fixes: 9f07af1d2742 ("net: phy: fixed_phy: initialize the link status as up")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/dab6c10e-725e-4648-9662-39cc821723d0@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove setting supported/advertised modes from fixed_phy_register2025-11-18T00:59:09+00:00Heiner Kallweithkallweit1@gmail.com2025-11-12T21:06:13+00:00urn:sha1:5860bb1ce0ddb9c5c964f7b46a8f0c4a48f919b1
This code was added with 34b31da486a5 ("phy: fixed_phy: Set supported
speed in phydev") 10 yrs ago. The commit message of this change
mentions a use case involving callback adjust_link of struct
dsa_switch_driver. This struct doesn't exist any longer, and in general
usage of the legacy fixed PHY has been removed from DSA with the switch
to phylink.
Note: Supported and advertised modes are now set by phy_probe() when
the fixed PHY is attached to the netdev and bound to the genphy driver.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/3abaa3c5-fbb9-4052-9346-6cb096a25878@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: initialize the link status as up2025-11-13T14:20:30+00:00Heiner Kallweithkallweit1@gmail.com2025-11-10T21:20:26+00:00urn:sha1:9f07af1d274223a4314b5e2e6d395a78166c24c5
All callers initialize the link status as up. This change is in line
with how of_phy_register_fixed_link() behaves.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/45f644e8-2292-4787-a27a-f69084c93218@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net: phy: fixed_phy: shrink size of struct fixed_phy_status2025-11-08T02:53:13+00:00Heiner Kallweithkallweit1@gmail.com2025-11-05T22:09:17+00:00urn:sha1:f73e0f46bbfab29b111ff52d047f15aa13623972
All three members are effectively of type bool, so make this explicit
and shrink size of struct fixed_phy_status.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/9eca3d7e-fa64-4724-8fdc-f2c1a8f2ae8f@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove fixed_phy_add2025-11-05T02:46:14+00:00Heiner Kallweithkallweit1@gmail.com2025-10-30T21:46:32+00:00urn:sha1:5de9ea1c50f061892625388880e83fdc50a4ef66
fixed_phy_add() has a number of problems/disadvantages:
- It uses phy address 0 w/o checking whether a fixed phy with this
address exists already.
- A subsequent call to fixed_phy_register() would also use phy address 0,
because fixed_phy_add() doesn't mark it as used.
- fixed_phy_add() is used from platform code, therefore requires that
fixed_phy code is built-in.
Now that for the only two users (coldfire/5272 and bcm47xx) fixed_phy
creation has been moved to the respective ethernet driver (fec, b44),
we can remove fixed_phy_add().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/bee046a1-1e77-4057-8b04-fdb2a1bbbd08@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: add helper fixed_phy_register_100fd2025-11-05T02:46:13+00:00Heiner Kallweithkallweit1@gmail.com2025-10-30T21:41:19+00:00urn:sha1:c9445e3c087656e01d0160a48f90389856baf368
In few places a 100FD fixed PHY is used. Create a helper so that users
don't have to define the struct fixed_phy_status.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/bf564b19-e9bc-4896-aeae-9f721cc4fecd@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove struct fixed_mdio_bus2025-09-10T01:11:55+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:02:44+00:00urn:sha1:2983825579358887a59cd9f76d55d5f54f659ebf
Use two separate static variables instead of the struct, this allows
to simplify the code.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: add helper fixed_phy_find2025-09-10T01:11:53+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:01:52+00:00urn:sha1:f8db55c8eb8e9d958694bae6958d5a3467caabb2
Factor out the functionality to search for a fixed_phy matching an
address. This improves readability of the code.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove member no_carrier from struct fixed_phy2025-09-10T01:11:50+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:01:02+00:00urn:sha1:0625b3bfbb7f5706d83fa1fd3f8a30a5fded108f
After the recent removal of gpio support member no_carrier isn't
needed any longer.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>