kernel/linux.git/drivers/net/phy/fixed_phy.c, branch v6.18.21Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.18.212025-09-10T01:11:55+00:00net: phy: fixed_phy: remove struct fixed_mdio_bus2025-09-10T01:11:55+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:02:44+00:00urn:sha1:2983825579358887a59cd9f76d55d5f54f659ebf
Use two separate static variables instead of the struct, this allows
to simplify the code.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: add helper fixed_phy_find2025-09-10T01:11:53+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:01:52+00:00urn:sha1:f8db55c8eb8e9d958694bae6958d5a3467caabb2
Factor out the functionality to search for a fixed_phy matching an
address. This improves readability of the code.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove member no_carrier from struct fixed_phy2025-09-10T01:11:50+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:01:02+00:00urn:sha1:0625b3bfbb7f5706d83fa1fd3f8a30a5fded108f
After the recent removal of gpio support member no_carrier isn't
needed any longer.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove unused interrupt support2025-09-10T01:11:47+00:00Heiner Kallweithkallweit1@gmail.com2025-09-06T22:00:10+00:00urn:sha1:fecf7087f0a32151f146ce6c6a7fd30b4b1a838d
The two callers of __fixed_phy_add() both pass PHY_POLL, so we can
remove the irq argument to simplify the function.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: remove link gpio support2025-09-06T00:45:10+00:00Heiner Kallweithkallweit1@gmail.com2025-09-04T06:08:18+00:00urn:sha1:43a42b85162aa1430556d58bbde05b54786a2c5a
The only user of fixed_phy gpio functionality was here:
arch/arm/boot/dts/nxp/vf/vf610-zii-dev-rev-b.dts
Support for the switch on this board was migrated to phylink
(DSA - mv88e6xxx) years ago, so the functionality is unused now.
Therefore remove it.
Note: There is a very small risk that there's out-of-tree users
who use link gpio with a switch chip not handled by DSA.
However we care about in-tree device trees only.
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/75295a9a-e162-432c-ba9f-5d3125078788@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: simplify fixed_mdio_read2025-08-28T01:09:08+00:00Heiner Kallweithkallweit1@gmail.com2025-08-26T19:24:44+00:00urn:sha1:6aff3699906bd1017fd9017bed133681b0eb8a42
swphy_read_reg() doesn't change the passed struct fixed_phy_status,
so we can pass &fp->status directly.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Link: https://patch.msgid.link/c49195c7-a3a1-485c-baed-9b33740752de@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: let fixed_phy_unregister free the phy_device2025-08-27T00:19:40+00:00Heiner Kallweithkallweit1@gmail.com2025-08-23T21:25:05+00:00urn:sha1:a0f849c1cc6df0db9083b4c81c05a5456b1ed0fb
fixed_phy_register() creates and registers the phy_device. To be
symmetric, we should not only unregister, but also free the phy_device
in fixed_phy_unregister(). This allows to simplify code in users.
Note wrt of_phy_deregister_fixed_link():
put_device(&phydev->mdio.dev) and phy_device_free(phydev) are identical.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/ad8dda9a-10ed-4060-916b-3f13bdbb899d@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed: let fixed_phy_add always use addr 0 and remove return value2025-08-27T00:19:02+00:00Heiner Kallweithkallweit1@gmail.com2025-08-22T20:36:11+00:00urn:sha1:39e94fdce45fa611abf48472873e4ba2f67228a3
We have only two users of fixed_phy_add(), both use address 0 and
ignore the return value. So simplify fixed_phy_add() accordingly.
Whilst at it, constify the fixed_phy_status configs.
Note:
fixed_phy_add() is a legacy function which shouldn't be used in new
code, as it's use may be problematic:
- No check whether a fixed phy exists already at the given address
- If fixed_phy_register() is called afterwards by any other driver,
then it will also use phy_addr 0, because fixed_phy_add() ignores
the ida which manages address assignment
Drivers using a fixed phy created by fixed_phy_add() in platform code,
should dynamically create a fixed phy with fixed_phy_register()
instead.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/762700e5-a0b1-41af-aa03-929822a39475@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed: remove usage of a faux device2025-08-15T19:27:00+00:00Heiner Kallweithkallweit1@gmail.com2025-08-13T19:18:03+00:00urn:sha1:d0f110773d776f919f93ba2e7dc254f80a7297b2
A struct mii_bus doesn't need a parent, so we can simplify the code and
remove using a faux device. Only difference is the following in sysfs
under /sys/class/mdio_bus:
old: fixed-0 -> '../../devices/faux/Fixed MDIO bus/mdio_bus/fixed-0'
new: fixed-0 -> ../../devices/virtual/mdio_bus/fixed-0
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/e9426bb9-f228-4b99-bc09-a80a958b5a93@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net: phy: fixed_phy: constify status argument where possible2025-05-21T01:17:43+00:00Heiner Kallweithkallweit1@gmail.com2025-05-17T20:37:29+00:00urn:sha1:4ba1c5bb4811f560a86697311cb4e9741e047a5d
Constify the passed struct fixed_phy_status *status where possible.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/d1764b62-8538-408b-a4e3-b63715481a38@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>