kernel/linux.git/drivers/net/hyperv/netvsc.c, branch v4.9.331

netvsc: Deal with rescinded channels correctly

2018-03-24T10:00:13+00:00

[ Upstream commit 73e64fa4f417b22d8d5521999a631ced8e2d442e ] We will not be able to send packets over a channel that has been rescinded. Make necessary adjustments so we can properly cleanup even when the channel is rescinded. This issue can be trigerred in the NIC hot-remove path. Signed-off-by: K. Y. Srinivasan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman

Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-02-14T23:25:39+00:00

commit 433e19cf33d34bb6751c874a9c00980552fe508c upstream. Commit a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read()") added the proper mb(), but removed the test "prev_write_sz < pending_sz" when making the signal decision. As a result, the guest can signal the host unnecessarily, and then the host can throttle the guest because the host thinks the guest is buggy or malicious; finally the user running stress test can perceive intermittent freeze of the guest. This patch brings back the test, and properly handles the in-place consumption APIs used by NetVSC (see get_next_pkt_raw(), put_pkt_raw() and commit_rd_index()). Fixes: a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read()") Signed-off-by: Dexuan Cui Reported-by: Rolf Neugebauer Tested-by: Rolf Neugebauer Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Signed-off-by: K. Y. Srinivasan Cc: Rolf Neugebauer Signed-off-by: Greg Kroah-Hartman

hv_netvsc: use consume_skb

2016-09-23T12:39:48+00:00

Packets that are transmitted in normal path should use consume_skb instead of kfree_skb. This allows for better tracing of packet drops. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

Revert "hv_netvsc: make inline functions static"

2016-09-11T04:23:00+00:00

These functions are used by other code misc-next tree. This reverts commit 30d1de08c87ddde6f73936c3350e7e153988fe02. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

hv_netvsc: make variable local

2016-08-23T19:05:37+00:00

The variable m_ret is only used in one basic block. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

hv_netvsc: make netvsc_destroy_buf void

2016-08-23T19:05:37+00:00

No caller checks the return value. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

hv_netvsc: refactor completion function

2016-08-23T19:05:37+00:00

Break the different cases, code is cleaner if broken up Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

hv_netvsc: init completion during alloc

2016-08-23T19:05:37+00:00

Move initialization to allocate where other fields are initialized. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

hv_netvsc: make device_remove void

2016-08-23T19:05:37+00:00

Always returns 0 and no callers check. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller

hv_netvsc: use ARRAY_SIZE() for NDIS versions

2016-08-23T19:05:36+00:00

Don't hard code size of array of NDIS versions. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller