kernel/linux.git/drivers/net/dsa/dsa_loop.c, branch v4.14.2

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-09-06T03:03:35+00:00

net: dsa: loop: Do not unregister invalid fixed PHY

2017-09-04T03:18:25+00:00

During error injection it was possible to crash in dsa_loop_exit() because of an attempt to unregister an invalid PHY. We actually want to the driver probing in dsa_loop_init() even though fixed_phy_register() may return an error to exercise how DSA deals with such cases, but we should not be crashing during driver removal. Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller

net: dsa: make dsa_switch_ops const

2017-08-10T05:42:49+00:00

Make these structures const as they are only stored in the ops field of a dsa_switch structure, which is const. Done using Coccinelle. Signed-off-by: Bhumika Goyal Reviewed-by: Vivien Didelot Signed-off-by: David S. Miller

net: dsa: Remove support for vlan dump from DSA's drivers

2017-08-07T21:48:48+00:00

This is done as a preparation before removing support for vlan dump from DSA core. The vlans are synced with the bridge and thus there is no need for special dump operation support. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller

net: dsa: loop: Implement ethtool statistics

2017-06-16T16:43:48+00:00

When a DSA driver implements ethtool statistics, we also override the master network device's ethtool statistics with the CPU port's statistics and this has proven to be a possible source of bugs in the past. Enhance the dsa_loop.c driver to provide statistics under the forme of ok/error reads and writes from the per-port PHY read/writes. Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller

net: dsa: loop: Inline unregister_fixed_phys()

2017-06-16T16:43:48+00:00

This is a simple function that only gets used in the driver's remove function, inline it there. Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller

net: dsa: remove dev arg of dsa_register_switch

2017-05-31T16:35:43+00:00

The current dsa_register_switch function takes a useless struct device pointer argument, which always equals ds->dev. Drivers either call it with ds->dev, or with the same device pointer passed to dsa_switch_alloc, which ends up being assigned to ds->dev. This patch removes the second argument of the dsa_register_switch and _dsa_register_switch functions. Signed-off-by: Vivien Didelot Signed-off-by: David S. Miller

net: dsa: use switchdev_obj_dump_cb_t everywhere

2017-05-18T14:40:12+00:00

Now that the DSA public header includes switchdev.h, use the provided switchdev_obj_dump_cb_t typedef for the object dump callback. Signed-off-by: Vivien Didelot Signed-off-by: David S. Miller

net: dsa: include switchdev.h only once

2017-05-18T14:40:12+00:00

DSA drivers and core use switchdev. Include switchdev.h only once, in the dsa.h public header, so that inclusion in DSA drivers or forward declarations of switchdev structures in not necessary anymore. Signed-off-by: Vivien Didelot Signed-off-by: David S. Miller

net: dsa: loop: Check for memory allocation failure

2017-05-08T18:58:36+00:00

If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. Return -ENOMEM instead, as done for some other memory allocation just a few lines above. Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") Signed-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Acked-by: Florian Fainelli Signed-off-by: David S. Miller