kernel/linux.git/drivers/net/bonding, branch linux-2.6.22.y

NET: Share correct feature code between bridging and bonding

2007-08-31T06:01:00+00:00

[NET]: Share correct feature code between bridging and bonding http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the bonding driver may produce bogus combinations of the checksum flags and SG/TSO. For example, if you bond devices with NETIF_F_HW_CSUM and NETIF_F_IP_CSUM you'll end up with a bonding device that has neither flag set. If both have TSO then this produces an illegal combination. The bridge device on the other hand has the correct code to deal with this. In fact, the same code can be used for both. So this patch moves that logic into net/core/dev.c and uses it for both bonding and bridging. In the process I've made small adjustments such as only setting GSO_ROBUST if at least one constituent device supports it. Signed-off-by: Herbert Xu Acked-by: David S. Miller Signed-off-by: Greg Kroah-Hartman

bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-20T23:12:41+00:00

Modify carrier state determination for 802.3ad mode to comply with section 43.3.9 of IEEE 802.3, which requires that "Links that are not successful candidates for aggregation (e.g., links that are attached to other devices that cannot perform aggregation or links that have been manually configured to be non-aggregatable) are enabled to operate as individual IEEE 802.3 links." Bug reported by Laurent Chavey . This patch is an updated version of his patch that changes the wording of commentary and adds an update to the driver version. Signed-off-by: Jay Vosburgh Signed-off-by: Laurent Chavey Signed-off-by: Jeff Garzik

bonding: Fix use after free in unregister path

2007-06-20T23:12:41+00:00

The following patch (based on a patch from Stephen Hemminger ) removes use after free conditions in the unregister path for the bonding master. Without this patch, an operation of the form "echo -bond0 > /sys/class/net/bonding_masters" would trigger a NULL pointer dereference in sysfs. I was not able to induce the failure with the non-sysfs code path, but for consistency I updated that code as well. I also did some testing of the bonding /proc file being open while the bond is being deleted, and didn't see any problems there. Signed-off-by: Jay Vosburgh Signed-off-by: Jeff Garzik

Fix occurrences of "the the "

2007-05-09T06:57:56+00:00

Signed-off-by: Michael Opdenacker Signed-off-by: Adrian Bunk

[NET]: Remove NETIF_F_INTERNAL_STATS, default to internal stats.

2007-04-29T04:04:03+00:00

Herbert Xu conviced me that a new flag was overkill; every driver currently overrides get_stats, so we might as well make the internal one the default. If someone did fail to set get_stats, they would now get all 0 stats instead of "No statistics available". Signed-off-by: Rusty Russell Acked-by: Herbert Xu Signed-off-by: David S. Miller

[NET]: Inline net_device_stats

2007-04-26T05:28:26+00:00

Network drivers which keep stats allocate their own stats structure then write a get_stats() function to return them. It would be nice if this were done by default. 1) Add a new "stats" field to "struct net_device". 2) Add a new feature field to say "this driver uses the internal one" 3) Have a default "get_stats" which returns NULL if that feature not set. 4) Change callers to check result of get_stats call for NULL, not if ->get_stats is set. This should not break backwards compatibility with older drivers, yet allow modern drivers to shed some boilerplate code. Lightly tested: works for a modified lguest network driver. Signed-off-by: Rusty Russell Signed-off-by: David S. Miller

[SK_BUFF]: unions of just one member don't get anything done, kill them

2007-04-26T05:26:20+00:00

Renaming skb->h to skb->transport_header, skb->nh to skb->network_header and skb->mac to skb->mac_header, to match the names of the associated helpers (skb[_[re]set]_{transport,network,mac}_header). Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: David S. Miller

[SK_BUFF]: Introduce ipv6_hdr(), remove skb->nh.ipv6h

2007-04-26T05:25:14+00:00

Now the skb->nh union has just one member, .raw, i.e. it is just like the skb->mac union, strange, no? I'm just leaving it like that till the transport layer is done with, when we'll rename skb->mac.raw to skb->mac_header (or ->mac_header_offset?), ditto for ->{h,nh}. Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: David S. Miller

[SK_BUFF]: Introduce arp_hdr(), remove skb->nh.arph

2007-04-26T05:25:12+00:00

Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: David S. Miller

[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph

2007-04-26T05:25:10+00:00

Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: David S. Miller