kernel/linux.git/drivers/mtd/ubi/attach.c, branch v4.4.171

ubi: Be more paranoid while seaching for the most recent Fastmap

2018-07-25T08:18:32+00:00

commit 74f2c6e9a47cf4e508198c8594626cc82906a13d upstream. Since PEB erasure is asynchornous it can happen that there is more than one Fastmap on the MTD. This is fine because the attach logic will pick the Fastmap data structure with the highest sequence number. On a not so well configured MTD stack spurious ECC errors are common. Causes can be different, bad hardware, wrong operating modes, etc... If the most current Fastmap renders bad due to ECC errors UBI might pick an older Fastmap to attach from. While this can only happen on an anyway broken setup it will show completely different sympthoms and makes finding the root cause much more difficult. So, be debug friendly and fall back to scanning mode of we're facing an ECC error while scanning for Fastmap. Cc: Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman

ubi: Rework Fastmap attach base code

2018-07-25T08:18:32+00:00

commit fdf10ed710c0aa177e8dfcd84e65e4e5e8e0956b upstream. Introduce a new list to the UBI attach information object to be able to deal better with old and corrupted Fastmap eraseblocks. Also move more Fastmap specific code into fastmap.c. Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman

ubi: Introduce vol_ignored()

2018-07-25T08:18:32+00:00

commit 243a4f8126fcf7facb04b324dbb7c85d10b11ce9 upstream. This makes the logic more easy to follow. Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman

UBI: drop null test before destroy functions

2015-10-03T18:36:10+00:00

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall Signed-off-by: Richard Weinberger

UBI: Fastmap: Fall back to scanning mode after ECC error

2015-03-26T22:03:15+00:00

If we encounter an uncorrectable ECC error while scanning for the fastmap UBI must not fail hard. Instead fall back to scanning mode. Reported-by: Alexander Block Signed-off-by: Richard Weinberger

UBI: Fastmap: Make self_check_eba() depend on fastmap self checking

2015-03-26T21:46:05+00:00

...instead of generic self checking. Signed-off-by: Richard Weinberger

UBI: Remove alloc_ai() slab name from parameter list

2015-03-26T21:45:57+00:00

There is always exactly one ubi_attach_info object allocated, therefore we don't have to care about the name. Signed-off-by: Richard Weinberger

UBI: Fastmap: Fix memory leak while attaching

2015-03-26T21:45:57+00:00

Currently we leak a few ubi_ainf_pebs while attaching. Signed-off-by: Richard Weinberger

UBI: account for bitflips in both the VID header and data

2015-03-26T11:07:17+00:00

We are completely discarding the earlier value of 'bitflips', which could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the bitwise OR of header and data 'bitflip' statuses instead. Coverity CID #1226856 Cc: stable Signed-off-by: Brian Norris Signed-off-by: Richard Weinberger

UBI: Extend UBI layer debug/messaging capabilities

2014-11-07T10:08:51+00:00

If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to all ubi layer message types. The R/O block driver messages were replaced by pr_* since ubi_device structure is not used by it. Amended a bit by Artem. Signed-off-by: Tanya Brokhman Signed-off-by: Artem Bityutskiy