kernel/linux.git/drivers/mmc/core/core.c, branch v4.14.217

mmc: avoid removing non-removable hosts during suspend

2018-03-24T10:01:24+00:00

[ Upstream commit de8dcc3d2c0e08e5068ee1e26fc46415c15e3637 ] The Weibu F3C MiniPC has an onboard AP6255 module, presenting two SDIO functions on a single MMC host (Bluetooth/btsdio and WiFi/brcmfmac), and the mmc layer correctly detects this as non-removable. After suspend/resume, the wifi and bluetooth interfaces disappear and do not get probed again. The conditions here are: 1. During suspend, we reach mmc_pm_notify() 2. mmc_pm_notify() calls mmc_sdio_pre_suspend() to see if we can suspend the SDIO host. However, mmc_sdio_pre_suspend() returns -ENOSYS because btsdio_driver does not have a suspend method. 3. mmc_pm_notify() proceeds to remove the card 4. Upon resume, mmc_rescan() does nothing with this host, because of the rescan_entered check which aims to only scan a non-removable device a single time (i.e. during boot). Fix the loss of functionality by detecting that we are unable to suspend a non-removable host, so avoid the forced removal in that case. The comment above this function already indicates that this code was only intended for removable devices. Signed-off-by: Daniel Drake Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman

mmc: core: Turn off CQE before sending commands

2017-08-30T13:03:33+00:00

CQE needs to be off for the host controller to accept non-CQ commands. Turn off the CQE before sending commands, and ensure it is off in any reset or power management paths, or re-tuning. Signed-off-by: Adrian Hunter Reviewed-by: Linus Walleij Signed-off-by: Ulf Hansson

mmc: core: remove the check of mmc_card_blockaddr for SD cards

2017-08-30T12:01:51+00:00

Per the SD physical layer simplified specification V4.10, section 4.6.2, CSD version 1.0 SD card should use taac, nsac and r2w_factor for calculating the data access time. But the taac and nsac for SDHC(CSD version 2.0) are always fixed and the software should use the recommended value for timeout. When parsing the CSD, we sanely set them to zero for SDHC(CSD version 2.0), all the calculation for timeout_ns and timeout_clk is zero as well. So what we actually want to limit here is either SDHC case or unreasonable timeout reported by the cards. In principle we should at least be able to remove the bogus check for the mmc_card_blockaddr. Signed-off-by: Shawn Lin Signed-off-by: Ulf Hansson

mmc: core: correct taac parameter according to the specification

2017-08-30T12:01:46+00:00

Per the spec of JESD84-B51, section 7.3, replace tacc with taac to fix the obvious typo. Signed-off-by: Shawn Lin Signed-off-by: Ulf Hansson

mmc: Convert to using %pOF instead of full_name

2017-08-30T12:01:36+00:00

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Cc: Ulf Hansson Cc: Ludovic Desroches Cc: Jan Glauber Cc: David Daney Cc: "Steven J. Hill" Cc: linux-mmc@vger.kernel.org Acked-by: David Daney Tested-by: Steven J. Hill Acked-by: Ludovic Desroches Signed-off-by: Ulf Hansson

mmc: core: turn the pr_info under CONFIG_MMC_DEBUG into pr_debug

2017-08-30T12:01:34+00:00

There are lots of debug message in core.c which use pr_debug for better dynamic log level control. So it doesn't make sense for those print to still keep working only under CONFIG_MMC_DEBUG. Signed-off-by: Shawn Lin Signed-off-by: Ulf Hansson

mmc: core: always check the length of sglist with total data size

2017-08-30T12:01:33+00:00

All the check within mmc_mrq_prep seems to be all-or-none proposition, so it doesn't make sense to only check the length of sglist only under the CONFIG_MMC_DEBUG context. I'd prefer to always keep the check there unconditionally. Signed-off-by: Shawn Lin Signed-off-by: Ulf Hansson

mmc: core: remove check of host->removed for rescan routine

2017-08-30T12:01:33+00:00

The intention of this check was to prevent the conflict between hotplug and removing driver for whatever reason. Currently it doesn't improve anything and the following rescan process could still saftly perform the scan flow. So these code seems pointless now and let's remove them. Signed-off-by: Shawn Lin Signed-off-by: Ulf Hansson

mmc: slot-gpio: Add support to enable irq wake on cd_irq

2017-06-20T08:30:49+00:00

Add host capability MMC_CAP_CD_WAKE to enable irq wake on the card detect irq. Signed-off-by: Adrian Hunter Signed-off-by: Ulf Hansson

mmc: core: Move mmc_flush_cache() from core.c to mmc_ops.c

2017-06-20T08:30:44+00:00

The mmc_flush_cache() is a eMMC specific function, let's move it to mmc_ops.c to make that clear. Signed-off-by: Ulf Hansson Reviewed-by: Linus Walleij Reviewed-by: Shawn Lin