kernel/linux.git/drivers/media/rc/lirc_dev.c, branch v4.8.16

[media] lirc_dev: use LIRC_CAN_REC() define to check if the device can receive

2016-07-13T18:29:03+00:00

The LIRC_CAN_REC() returns a boolean "flag & LIRC_CAN_REC_MASK" to check whether the device can receive data. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: fix potential segfault

2016-07-13T18:28:25+00:00

When opening or closing a lirc character device, the framework provides to the user the possibility to keep track of opening or closing of the device by calling two functions: - set_use_inc() when opening the device - set_use_dec() when closing the device if those are not set by the lirc user, the system segfaults. Check the pointer value before calling the above functions. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: extremely trivial comment style fix

2016-07-13T18:27:16+00:00

Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: fix error return value

2016-07-13T18:26:52+00:00

If ioctl is called, it cannot be a case of invalid system call number (ENOSYS), that is a ENOTTY case which means that the device doesn't support that specific ioctl command. So, replace ENOSYS with ENOTTY. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: fix variable constant comparisons

2016-07-13T18:25:41+00:00

When comparing a variable with a constant, the comparison should start from the variable and not from the constant. It's also written in the human DNA. Swap the terms of comparisons whenever the constant comes first and fix the following checkpatch warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: merge three if statements in only one

2016-07-13T18:24:28+00:00

The three if statements check the same thing, merge them in only one statement. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: remove double if ... else statement

2016-07-13T18:09:05+00:00

There are two if ... else which check the same thing in different part of the code, they can be merged in a single check. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: simplify if statement in lirc_add_to_buf

2016-07-13T18:06:29+00:00

The whole function is inside an 'if' statement ("if (ir->d.add_to_buf)"). Check the opposite of that statement at the beginning and exit, this way we can have one level less of indentation. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: do not use goto to create loops

2016-07-13T18:01:13+00:00

... use "do .. while" instead. Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: simplify goto paths

2016-07-13T17:59:19+00:00

The code can be rearranged so that some goto paths can be removed Signed-off-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab