Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.4 2023-04-11T14:59:19+00:00 2023-04-11T14:59:19+00:00 Uwe Kleine-König u.kleine-koenig@pengutronix.de 2023-03-26T14:31:50+00:00 urn:sha1:17d32ccde1f313c783bc3cd56128c0731f32d92c The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-04-11T14:59:19+00:00 Uwe Kleine-König u.kleine-koenig@pengutronix.de 2023-03-26T14:31:49+00:00 urn:sha1:98e3987ae6f309bd68582438541ba1ff722b471e The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-04-11T14:59:19+00:00 Uwe Kleine-König u.kleine-koenig@pengutronix.de 2023-03-26T14:31:48+00:00 urn:sha1:d09a2fffe61e88f4051e488ed70bafc54cb2d747 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-04-11T14:59:19+00:00 Uwe Kleine-König u.kleine-koenig@pengutronix.de 2023-03-26T14:31:47+00:00 urn:sha1:cdf5e3835c47447aa6995828df1d420859f769f7 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-04-11T14:59:18+00:00 Uwe Kleine-König u.kleine-koenig@pengutronix.de 2023-03-26T14:31:46+00:00 urn:sha1:2fc7c4f35338dc9a6576304abfb70628bd90ccd9 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-04-11T14:59:18+00:00 Uwe Kleine-König u.kleine-koenig@pengutronix.de 2023-03-26T14:31:45+00:00 urn:sha1:a72b9869ece50cdd258c122b5ba403ae66a17d7f The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2023-02-08T06:30:13+00:00 Oleg Verych olecom@gmail.com 2023-01-07T08:37:49+00:00 urn:sha1:c07e734b7a65c7706319e24f9b14ec9d262fa50c When removing the module, balance PM runtime enable with the corresponding disable call. Signed-off-by: Oleg Verych <olecom@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> 2023-02-06T07:41:59+00:00 Oleg Verych olecom@gmail.com 2023-01-16T23:03:23+00:00 urn:sha1:c699ce1a3838465fb87ecd951f0819404e70030a Fix interrupt status register offset usage to be a defined name CSI_INT_STA_REG (= 0x34) instead of a plain number. Additionally fix a typo in a comment of the same file. Signed-off-by: Oleg Verych <olecom@gmail.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> 2022-12-12T10:36:00+00:00 Paul Kocialkowski paul.kocialkowski@bootlin.com 2022-12-08T14:20:00+00:00 urn:sha1:73402fd7ac098495cfb9b38132f3c174b8d8e6f2 Explicitly set ret to zero instead of assigning it and overwriting it later, which is a bit confusing to understand. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> 2022-12-12T10:36:00+00:00 Paul Kocialkowski paul.kocialkowski@bootlin.com 2022-12-08T14:19:59+00:00 urn:sha1:1607a95c0d81842ff3db8df9543a9bb5492d480a Explicitly set ret to zero instead of assigning it and overwriting it later, which is a bit confusing to understand. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>