kernel/linux.git/drivers/input/mouse/sentelic.c, branch v4.9.331

Input: sentelic - fix error return when fsp_reg_write fails

2020-08-21T09:02:10+00:00

[ Upstream commit ea38f06e0291986eb93beb6d61fd413607a30ca4 ] Currently when the call to fsp_reg_write fails -EIO is not being returned because the count is being returned instead of the return value in retval. Fix this by returning the value in retval instead of count. Addresses-Coverity: ("Unused value") Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20200603141218.131663-1-colin.king@canonical.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin

Input: sentelic - silence some underflow warnings

2015-08-21T16:32:59+00:00

I have a static checker that complains when we check for an upper bound but don't have a corresponding check for a lower bound. With this code, the upper bound check seems not really required, so it is not a bug to leave the lower bound check out as well. But let's silence the warning by making these variables unsigned. Signed-off-by: Dan Carpenter Signed-off-by: Dmitry Torokhov

Input: sentelic - only report position of first finger as ST coordinates

2012-12-24T17:51:21+00:00

Report only the position of the first finger as absolute non-MT coordinates, instead of reporting both fingers alternatively. Actual MT events are unaffected. This fixes horizontal and improves vertical scrolling with the touchpad. Cc: stable@vger.kernel.org Signed-off-by: Christophe TORDEUX Signed-off-by: Dmitry Torokhov

Merge branch 'next' into for-linus

2012-10-11T07:45:21+00:00

Prepare second set of updates for 3.7 merge window (Wacom driver update and patches extending number of input minors).

Input: sentelic - filter out erratic movement when lifting finger

2012-09-19T21:58:07+00:00

When lifing finger off the surface some versions of touchpad send movement packets with very low coordinates, which cause cursor to jump to the upper left corner of the screen. Let's ignore least significant bits of X and Y coordinates if higher bits are all zeroes and consider finger not touching the pad. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43197 Reported-and-tested-by: Aleksey Spiridonov Tested-by: Eddie Dunn Tested-by: Jakub Luzny Tested-by: Olivier Goffart Signed-off-by: Tai-hwa Liang Signed-off-by: Dmitry Torokhov

Input: MT - Add flags to input_mt_init_slots()

2012-09-19T17:50:18+00:00

Preparing to move more repeated code into the mt core, add a flags argument to the input_mt_slots_init() function. Reviewed-and-tested-by: Benjamin Tissoires Tested-by: Ping Cheng Acked-by: Dmitry Torokhov Signed-off-by: Henrik Rydberg

Input: sentelic - report device's production serial number

2012-05-11T03:39:04+00:00

Hardware since Cx supports an unique identity (used to identify OEM vendors and released lot number) which is very helpful for diagnostic purpose. This revision tries to make it as a part of driver boot up message. Whilst here, also bumping fsp_drv_ver to acknowledge recent addition of absolute coordinates output. Signed-off-by: Tai-hwa Liang Signed-off-by: Dmitry Torokhov

Input: sentelic - filter taps in absolute mode

2012-04-03T16:55:51+00:00

Taps in absolute positioning single-finger mode are currently reported as physical clicks by the driver. This should be handled by userspace, not the kernel. When a tap occurs, the FSP_PB0_LBTN bit is set, but the FSP_PB0_PHY_BTN is not. We use this to filter out physical clicks from taps. Signed-off-by: Oskari Saarenmaa Reviewed-by: Tai-hwa Liang Reviewed-by: Chase Douglas Signed-off-by: Dmitry Torokhov

Input: sentelic - improve packet debugging information

2012-03-26T00:18:18+00:00

Signed-off-by: Oskari Saarenmaa Signed-off-by: Tai-hwa Liang Signed-off-by: Dmitry Torokhov

Input: sentelic - minor code cleanup

2012-03-26T00:18:15+00:00

Improve code readability by converting yet another magic number into a pre-defined constant. Signed-off-by: Tai-hwa Liang Signed-off-by: Dmitry Torokhov