kernel/linux.git/drivers/input/misc/ims-pcu.c, branch v4.17.1

Input: ims-pcu - fix typo in the error message

2017-11-27T00:16:31+00:00

1. change "to" to "too". 2. move ")" to the front of "\n", which discovered by Joe Perches. Signed-off-by: Zhen Lei Reviewed-by: Joe Perches Signed-off-by: Dmitry Torokhov

Input: ims-psu - check if CDC union descriptor is sane

2017-10-20T00:20:06+00:00

Before trying to use CDC union descriptor, try to validate whether that it is sane by checking that intf->altsetting->extra is big enough and that descriptor bLength is not too big and not too small. Reported-by: Andrey Konovalov Signed-off-by: Dmitry Torokhov

Input: ims-pcu - constify attribute_group structures

2017-07-12T21:18:29+00:00

attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 13547 1600 0 15147 3b2b drivers/input/misc/ims-pcu.o File size After adding 'const': text data bss dec hex filename 13675 1472 0 15147 3b2b drivers/input/misc/ims-pcu.o Signed-off-by: Arvind Yadav Signed-off-by: Dmitry Torokhov

Input: ims-pcu - validate number of endpoints before using them

2017-03-16T20:56:51+00:00

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack control-interface endpoints. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Signed-off-by: Johan Hovold Cc: stable@vger.kernel.org # 3.10 Signed-off-by: Dmitry Torokhov

Input: ims-pcu - sanity check against missing interfaces

2016-03-17T21:16:57+00:00

A malicious device missing interface can make the driver oops. Add sanity checking. Signed-off-by: Oliver Neukum CC: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov

Merge branch 'next' into for-linus

2014-12-16T04:32:42+00:00

Prepare input updates for 3.19.

Input: initialize device counter variables with -1

2014-12-03T23:27:17+00:00

Let's initialize atomic_t variables keeping track of number of various devices created so far with -1 in order to avoid extra subtraction operation. Signed-off-by: Aniroop Mathur Signed-off-by: Dmitry Torokhov

Input: ims-pcu - fix dead code in ims_pcu_ofn_reg_addr_store()

2014-10-28T17:33:36+00:00

Coverity pointed out that at return point error is always 0 so the conditional is not needed. Signed-off-by: Dmitry Torokhov

Input: ims-pcu - fix uninitialized use of 'error' in ims_pcu_buffers_alloc()

2014-05-19T05:39:56+00:00

In case allocation via usb_alloc_coherent() fails in ims_pcu_buffers_alloc(), the function jumps to the exit path without initializing local variable 'error' that is used as return value. Detected by Coverity - CID 1016531. Signed-off-by: Christian Engelmayer Signed-off-by: Dmitry Torokhov

Input: ims-pcu - add commands supported by the new version of the FW

2014-02-12T23:09:48+00:00

New version of the PCU firmware supports two new commands: - IMS_PCU_CMD_OFN_SET_CONFIG which allows to write data to the registers of one finger navigation(OFN) chip present on the device - IMS_PCU_CMD_OFN_GET_CONFIG which allows to read data form the registers of said chip. This commit adds two helper functions to use those commands and sysfs attributes to use them. It also exposes some OFN configuration parameters via sysfs. Signed-off-by: Andrey Smirnov Signed-off-by: Dmitry Torokhov