kernel/linux.git/drivers/infiniband/ulp, branch linux-2.6.22.y

IPoIB/cm: Partial error clean up unmaps wrong address

2007-07-03T03:48:31+00:00

If a page can't be allocated for the frag list of a skb, the code to unmap the partially allocated list is off by one. For exaple, if 'frags' equals one, i == 0, and the alloc_page() fails, then the old loop would have unmapped mapping[1] which is uninitialized. The same would happen if the call to ib_dma_map_page() failed. Signed-off-by: Ralph Campbell Acked-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB/cm: Remove dead definition of struct ipoib_cm_id

2007-06-21T20:39:08+00:00

It's completely unused. Signed-off-by: Roland Dreier

IPoIB/cm: Fix interoperability when MTU doesn't match

2007-06-21T20:38:08+00:00

IPoIB connected mode currently rejects a connection request unless the supported MTU is >= the local netdevice MTU. This breaks interoperability with implementations that might have tweaked IPOIB_CM_MTU, and there's real no longer a reason to do so: this test is just a leftover from when we did not tweak MTU per-connection. Fix this by making the test as permissive as possible. Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB/cm: Initialize RX before moving QP to RTR

2007-06-21T20:03:50+00:00

Fix a crasher bug in IPoIB CM: once a QP is in the RTR state, a receive completion (or even an asynchronous error) might be observed on this QP, so we have to initialize all of our receive data structures before moving to the RTR state. As an optimization (since modify_qp might take a long time), the jiffies update done when moving RX to the passive_ids list is also left in place to reduce the chance of the RX being misdetected as stale. This fixes bug . Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB/cm: Fix performance regression on Mellanox

2007-05-29T23:07:09+00:00

commit 518b1646 ("IPoIB/cm: Fix SRQ WR leak") introduced a severe performance regression on Mellanox cards, because keeping a QP in the error state for extended periods of time moves hardware to the slow path (until the QP is destroyed). For example, MPI latency goes from ~3 usecs to ~7 usecs. Fix this by posting a send WR on one of the QPs that are being flushed, instead of using a separate drain QP that is kept in the error state. This fixes bug , reported and bisected by Scott Weitzenkamp at Cisco and debugged by Sasha Mikheev at Voltaire. Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB/cm: Drain cq in ipoib_cm_dev_stop()

2007-05-24T21:02:40+00:00

Since NAPI polling is disabled while ipoib_cm_dev_stop() is running, ipoib_cm_dev_stop() must poll the CQ itself in order to see the packets draining. Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB/cm: Fix timeout check in ipoib_cm_dev_stop()

2007-05-24T21:02:39+00:00

time_after() was used backwards, so the timeout occurred immediately. Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB/cm: Fix SRQ WR leak

2007-05-21T20:35:40+00:00

SRQ WR leakage has been observed with IPoIB/CM: e.g. flipping ports on and off will, with time, leak out all WRs and then all connections will start getting RNR NAKs. Fix this in the way suggested by spec: move the QP being destroyed to the error state, wait for "Last WQE Reached" event and then post WR on a "drain QP" connected to the same CQ. Once we observe a completion on the drain QP, it's safe to call ib_destroy_qp. Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IB/ipoib: Fix typos in error messages

2007-05-21T20:29:15+00:00

Trivial error message fixups. Signed-off-by: Michael S. Tsirkin Signed-off-by: Roland Dreier

IPoIB: Handle P_Key table reordering

2007-05-19T15:51:54+00:00

SM reconfiguration or failover possibly causes a shuffling of the values in the P_Key table. Right now, IPoIB only queries for the P_Key index once when it creates the device QP, and hence there are problems if the index of a P_Key value changes. Fix this by using the PKEY_CHANGE event to trigger a recheck of the P_Key index. Signed-off-by: Yosef Etigin Acked-by: Michael S. Tsirkin Signed-off-by: Roland Dreier