kernel/linux.git/drivers/infiniband/ulp/iser, branch v3.18.100

IB/iser: Fix sparse warnings

2017-05-08T05:44:09+00:00

commit 49df2781b101a729e9f46eddc845a587fc5665a8 upstream. Use uintptr_t to handle wr_id casting, which was found by Kbuild test robot and smatch. Also remove an internal definition of variable which potentially shadows an external one (and make sparse happy). Signed-off-by: Sagi Grimberg Signed-off-by: Or Gerlitz Signed-off-by: Roland Dreier Cc: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman

IB/iser: Fix wrong calculation of protection buffer length

2015-05-17T23:12:22+00:00

[ Upstream commit a065fe6aa25ba6ba93c02dc13486131bb3c64d5f ] This length miss-calculation may cause a silent data corruption in the DIX case and cause the device to reference unmapped area. Fixes: d77e65350f2d ('libiscsi, iser: Adjust data_length to include protection information') Signed-off-by: Sagi Grimberg Signed-off-by: Doug Ledford Signed-off-by: Sasha Levin

IB/iser: Use correct dma direction when unmapping SGs

2015-03-24T01:02:44+00:00

commit c6c95ef4cec680f7a10aa425a9970744b35b6489 upstream. We always unmap SGs with the same direction instead of unmapping with the direction the mapping was done, fix that. Fixes: 9a8b08fad2ef ("IB/iser: Generalize iser_unmap_task_data and [...]") Signed-off-by: Roi Dayan Signed-off-by: Or Gerlitz Signed-off-by: Roland Dreier Signed-off-by: Sasha Levin

IB/iser: Fix memory regions possible leak

2015-03-24T01:02:44+00:00

commit 6606e6a2ff2710b473838b291dc533cd8fc1471f upstream. When teardown process starts during live IO, we need to keep the memory regions pool (frmr/fmr) until all in-flight tasks are properly released, since each task may return a memory region to the pool. In order to do this, we pass a destroy flag to iser_free_ib_conn_res to indicate we can destroy the device and the memory regions pool. iser_conn_release will pass it as true and also DEVICE_REMOVAL event (we need to let the device to properly remove). Also, Since we conditionally call iser_free_rx_descriptors, remove the extra check on iser_conn->rx_descs. Fixes: 5426b1711fd0 ("IB/iser: Collapse cleanup and disconnect handlers") Reported-by: Or Gerlitz Signed-off-by: Sagi Grimberg Signed-off-by: Roland Dreier Signed-off-by: Sasha Levin

IB/iser: Fix possible SQ overflow

2015-01-27T16:29:37+00:00

commit 6ec9d4d2310e8fc54fc638e4454271d1fcaefa95 upstream. Fix a regression was introduced in commit 6df5a128f0fd ("IB/iser: Suppress scsi command send completions"). The sig_count was wrongly set to be static variable, thus it is possible that we won't reach to (sig_count % ISER_SIGNAL_BATCH) == 0 condition (due to races) and the send queue will be overflowed. Instead keep sig_count per connection. We don't need it to be atomic as we are safe under the iscsi session frwd_lock taken by libiscsi on the queuecommand path. Fixes: 6df5a128f0fd ("IB/iser: Suppress scsi command send completions") Signed-off-by: Max Gurtovoy Signed-off-by: Sagi Grimberg Signed-off-by: Or Gerlitz Signed-off-by: Roland Dreier Signed-off-by: Greg Kroah-Hartman

IB/mlx5, iser, isert: Add Signature API additions

2014-10-09T07:10:53+00:00

Expose more signature setting parameters. We modify the signature API to allow usage of some new execution parameters relevant to data integrity feature. This patch modifies ib_sig_domain structure by: - Deprecate DIF type in signature API (operation will be determined by the parameters alone, no DIF type awareness) - Add APPTAG check bitmask (for input domain) - Add REFTAG remap (increment) flag for each domain - Add APPTAG/REFTAG escape options for each domain The mlx5 driver is modified to follow the new parameters in HW signature setup. At the moment the callers (iser/isert) hard-code new parameters (by DIF type). In the future, callers will retrieve them from the scsi command structure. Signed-off-by: Sagi Grimberg Signed-off-by: Roland Dreier

IB/iser: Centralize ib_sig_domain settings

2014-10-09T07:10:53+00:00

Later there will be more parameters to set, so we want to do it in a centralized place. This patch does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Roland Dreier

IB/iser: Set IP_CSUM as default guard type

2014-10-09T07:10:53+00:00

In the future this will be a per-command parameter so we can lose it, but in the mean time IP_CSUM is a lot lighter for SW layers to compute, set it as default. Signed-off-by: Sagi Grimberg Signed-off-by: Roland Dreier

IB/iser: Remove redundant assignment

2014-10-09T07:10:53+00:00

We clear the struct before - no need to do 0 assignment. Signed-off-by: Sagi Grimberg Signed-off-by: Roland Dreier

IB/iser: Bump version, add maintainer

2014-10-09T07:06:46+00:00

Update the driver version and add Sagi Grimberg as maintainer Signed-off-by: Or Gerlitz Signed-off-by: Roland Dreier