kernel/linux.git/drivers/hwmon/max6697.c, branch linux-7.1.y

hwmon: (max6697) fix regmap leak on probe failure

2025-11-27T16:08:25+00:00

The i2c regmap allocated during probe is never freed. Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind. Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap") Cc: stable@vger.kernel.org # 6.12 Cc: Guenter Roeck Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20251127134351.1585-1-johan@kernel.org Signed-off-by: Guenter Roeck

hwmon: (max6697) Rely on subsystem locking

2025-10-15T18:02:43+00:00

Attribute access is now serialized in the hardware monitoring core, so locking in the driver code is no longer necessary. Drop it. Signed-off-by: Guenter Roeck

hwmon: (max6697) Document discrepancy in overtemperature status bit values

2024-07-31T17:43:53+00:00

In the MAX6581 datasheet Revision 0 to 3, the local channel overtemperature status is reported in bit 6 of register 0x45, and the overtemperature status for remote channel 7 is reported in bit 7. In Revision 4 and later, the local channel overtemperature status is reported in bit 7, and the remote channel 7 overtemperature status is reported in bit 6. A real chip was found to match the functionality documented in Revision 4 and later. The code was fixed with commit 1ea3fd1eb986 ("hwmon: (max6697) Fix swapped temp{1,8} critical alarms"). At that time it looked like this was an original bug. It only turned out later that the problem was the result of incorrect information in the chip datasheet. Document the discrepancy to avoid confusion caused by old versions of the datasheet. Cc: Tzung-Bi Shih Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Add support for tempX_min and tempX_min_alarm

2024-07-31T17:43:52+00:00

MAX6581 supports setting the minimum temperature as well as minimum temperature alarms. Add support for it. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Convert to with_info hwmon API

2024-07-31T17:43:52+00:00

Convert to with_info hwmon API to simplify the code and reduce its size. This patch reduces object file size by approximately 25%. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Convert to use regmap

2024-07-31T17:43:52+00:00

Use regmap for register caching, and use regmap API for bit operations to simplify the code. This patch reduces object file size by approximately 10%. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Use bit operations where possible

2024-07-31T17:43:52+00:00

Use bit operations to improve code maintainability. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Drop platform data support

2024-07-31T17:43:52+00:00

Platform data is not used anywhere in the upstram kernel. Drop support for it to simplify code maintenance. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Reorder include files

2024-07-31T17:43:52+00:00

Reorder include files to alphabetic order to improve maintainability. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max6697) Fix swapped temp{1,8} critical alarms

2024-07-14T18:49:01+00:00

The critical alarm bit for the local temperature sensor (temp1) is in bit 7 of register 0x45 (not bit 6), and the critical alarm bit for remote temperature sensor 7 (temp8) is in bit 6 (not bit 7). This only affects MAX6581 since all other chips supported by this driver do not support those critical alarms. Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles") Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck