kernel/linux.git/drivers/hwmon/max1619.c, branch linux-7.1.y

hwmon: (max1619) Improve chip detection code

2024-07-31T17:43:53+00:00

Bail out immediately if reading any of the registers used for chip detection fails, or if it returns an unexpected value. Drop all log messages from detection code. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max1619) Add support for update_interval attribute

2024-07-31T17:43:53+00:00

The chip supports reading and writing the conversion rate. Add support for the update_interval sysfs attribute. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max1619) Convert to with_info API

2024-07-31T17:43:53+00:00

Convert driver to with_info hwmon API to simplify the code and with it its maintainability. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max1619) Convert to use regmap

2024-07-31T17:43:53+00:00

Use regmap for local caching, to hide register read/write address differences, and for multi-byte operations. With this change, the driver specific lock is no longer necessary. While at it, check errors seen when initializing the chip and bail out if chip initialization fails. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max1619) Mask valid alarm bits

2024-07-31T17:43:53+00:00

Bit 0, 5, and 6 in the status register are reserved and, if set, do not indicate an alarm. Bit 7 is the 'busy' bit and also does not indicate an alarm. Mask the non-alarm bits to avoid reporting them to userspace. Cc: Tzung-Bi Shih Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max1619) Reorder include files to alphabetic order

2024-07-31T17:43:53+00:00

Simplify maintenance by reordering include files to alphabetic order. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: (max1619) Clamp temperature range when writing limits

2024-07-31T17:43:53+00:00

Module test code reports underflows when writing sensor limits. temp2_min: Suspected underflow: [min=-77000, read 101000, written -2147483648] temp2_max: Suspected underflow: [min=-77000, read 101000, written -2147483648] temp2_crit: Suspected underflow: [min=-77000, read 101000, written -2147483648] Clamp temperature ranges when writing limits to fix the problem. While at it, use sign_extend32() when reading temperatures to make the code easier to understand. Reviewed-by: Tzung-Bi Shih Signed-off-by: Guenter Roeck

hwmon: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-05-01T14:47:49+00:00

These drivers don't use the driver_data member of struct i2c_device_id, so don't explicitly initialize this member. This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's also a nice cleanup on its own. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20240430085654.1028864-2-u.kleine-koenig@pengutronix.de Signed-off-by: Guenter Roeck

hwmon: Switch i2c drivers back to use .probe()

2023-06-08T13:41:17+00:00

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230505131718.1210071-1-u.kleine-koenig@pengutronix.de [groeck: Added missing change in pmbus/acbel-fsg032.c] Signed-off-by: Guenter Roeck

hwmon: move from strlcpy with unused retval to strscpy

2022-09-19T13:17:05+00:00

Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang Link: https://lore.kernel.org/r/20220818210014.6769-1-wsa+renesas@sang-engineering.com Signed-off-by: Guenter Roeck