kernel/linux.git/drivers/hwmon/max1111.c, branch linux-4.16.y

hwmon: (max1111) use permission-specific DEVICE_ATTR variants

2017-01-02T18:19:45+00:00

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall [groeck: Updated description] Signed-off-by: Guenter Roeck

hwmon: (max1111) Return -ENODEV from max1111_read_channel if not instantiated

2016-03-27T17:37:48+00:00

arm:pxa_defconfig can result in the following crash if the max1111 driver is not instantiated. Unhandled fault: page domain fault (0x01b) at 0x00000000 pgd = c0004000 [00000000] *pgd=00000000 Internal error: : 1b [#1] PREEMPT ARM Modules linked in: CPU: 0 PID: 300 Comm: kworker/0:1 Not tainted 4.5.0-01301-g1701f680407c #10 Hardware name: SHARP Akita Workqueue: events sharpsl_charge_toggle task: c390a000 ti: c391e000 task.ti: c391e000 PC is at max1111_read_channel+0x20/0x30 LR is at sharpsl_pm_pxa_read_max1111+0x2c/0x3c pc : [] lr : [] psr: 20000013 ... [] (max1111_read_channel) from [] (sharpsl_pm_pxa_read_max1111+0x2c/0x3c) [] (sharpsl_pm_pxa_read_max1111) from [] (spitzpm_read_devdata+0x5c/0xc4) [] (spitzpm_read_devdata) from [] (sharpsl_check_battery_temp+0x78/0x110) [] (sharpsl_check_battery_temp) from [] (sharpsl_charge_toggle+0x48/0x110) [] (sharpsl_charge_toggle) from [] (process_one_work+0x14c/0x48c) [] (process_one_work) from [] (worker_thread+0x3c/0x5d4) [] (worker_thread) from [] (kthread+0xd0/0xec) [] (kthread) from [] (ret_from_fork+0x14/0x24) This can occur because the SPI controller driver (SPI_PXA2XX) is built as module and thus not necessarily loaded. While building SPI_PXA2XX into the kernel would make the problem disappear, it appears prudent to ensure that the driver is instantiated before accessing its data structures. Cc: Arnd Bergmann Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck

spi: Drop owner assignment from spi_drivers

2015-10-28T01:30:17+00:00

An spi_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Andrew F. Davis Acked-by: Jonathan Cameron Signed-off-by: Mark Brown

hwmon: (max1111) remove unnecessary OOM messages

2014-05-21T23:02:22+00:00

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han Acked-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: remove use of __devexit

2012-11-28T19:50:34+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton Cc: Hans de Goede Cc: Jean Delvare Cc: Alistair John Strachan Cc: Fenghua Yu Cc: Juerg Haefliger Cc: Andreas Herrmann Cc: Clemens Ladisch Cc: Rudolf Marek Cc: Jim Cromie Cc: "Mark M. Hoffman" Cc: Roger Lucas Acked-by: Guenter Roeck Acked-by: Mark Brown Signed-off-by: Greg Kroah-Hartman

hwmon: remove use of __devinit

2012-11-28T19:49:40+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton Cc: Hans de Goede Cc: Jean Delvare Cc: Alistair John Strachan Cc: Fenghua Yu Cc: Juerg Haefliger Cc: Andreas Herrmann Cc: Clemens Ladisch Cc: Rudolf Marek Cc: Jim Cromie Cc: "Mark M. Hoffman" Cc: Roger Lucas Acked-by: Guenter Roeck Acked-by: Mark Brown Signed-off-by: Greg Kroah-Hartman

hwmon: remove use of __devexit_p

2012-11-28T19:48:59+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Signed-off-by: Bill Pemberton Cc: Hans de Goede Cc: Jean Delvare Cc: Alistair John Strachan Cc: Fenghua Yu Cc: Juerg Haefliger Cc: Andreas Herrmann Cc: Clemens Ladisch Cc: Rudolf Marek Cc: Jim Cromie Cc: "Mark M. Hoffman" Cc: Roger Lucas Acked-by: Guenter Roeck Acked-by: Mark Brown Signed-off-by: Greg Kroah-Hartman

hwmon: (max1111) Add support for MAX1110, MAX1112, and MAX1113

2012-09-24T04:08:34+00:00

MAX1110 is similar to MAX1111, with 8 instead of 4 channels. MAX1112 and MAX1113 are similar to MAX1110 and MAX1111, with 4.096V reference voltage instead of 2.048V. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare

hwmon: (max1111) Convert to use devm_ functions

2012-07-22T04:48:41+00:00

Convert to use devm_ functions to reduce code size and simplify the code. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare

hwmon: (max1111) Fix multi-line comments

2012-03-19T01:27:17+00:00

Signed-off-by: Guenter Roeck