kernel/linux.git/drivers/hwmon/lm92.c, branch linux-4.4.y

hwmon: (lm92) Prevent overflow problem when writing large limits

2014-08-06T00:48:52+00:00

On platforms with sizeof(int) < sizeof(long), writing a temperature limit larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from long to int to fix the problem. The hysteresis temperature range depends on the value of data->temp[attr->index], since val is subtracted from it. Use a wider clamp, [-120000, 220000] should do to cover the possible range. Also add missing TEMP_TO_REG() on writes into cached hysteresis value. Also uses clamp_val to simplify the code a bit. Signed-off-by: Axel Lin [Guenter Roeck: Fixed double TEMP_TO_REG on hysteresis updates] Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck

hwmon: (lm92) Convert to use devm_hwmon_device_register_with_groups

2014-05-21T23:02:21+00:00

Use devm_hwmon_device_register_with_groups API to attach attributes to hwmon device, simplify code, and reduce code size. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm92) Drop function macros

2014-05-21T23:02:21+00:00

Function macros obfuscate code and increase code size, so drop them. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm92) Drop FSF mailing address

2014-05-21T23:02:21+00:00

The FSF mailing address may change, so drop it. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm92) Drop unnecessary forward declaration

2014-05-21T23:02:21+00:00

Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: Avoid initializing the same field twice

2014-04-04T16:01:34+00:00

All hwmon drivers allocate their data structure with some form of kzalloc, so setting data fields to zero explicitly is a waste of time. Signed-off-by: Jean Delvare Reviewed-by: Guenter Roeck

Update Jean Delvare's e-mail address

2014-01-29T19:40:08+00:00

Signed-off-by: Jean Delvare

hwmon: Add missing inclusions of

2012-10-10T13:25:56+00:00

Many hwmon drivers use jiffies but omit the inclusion of the header file. Fix that, and also fix one driver which was including the header file but didn't need it. Signed-off-by: Jean Delvare Acked-by: Guenter Roeck Acked-by: Luca Tettamanti Cc: Marc Hulsman Cc: Rudolf Marek

hwmon: (lm92) Convert to use devm_ functions

2012-07-22T04:48:41+00:00

Convert to use devm_ functions to reduce code size and simplify the code. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare

hwmon: (lm92) Fix checkpatch issues

2012-03-19T01:27:05+00:00

Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '*=' (ctx:VxV) ERROR: trailing whitespace WARNING: line over 80 characters WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line WARNING: simple_strtol is obsolete, use kstrtol instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Jean Delvare Signed-off-by: Guenter Roeck