kernel/linux.git/drivers/hwmon/lm85.c, branch linux-4.16.y

hwmon: (lm85) Add OF device ID table

2017-04-02T14:01:53+00:00

The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas Signed-off-by: Guenter Roeck

hwmon: (lm85) use permission-specific DEVICE_ATTR variants

2017-01-02T18:19:45+00:00

Use DEVICE_ATTR_RO for read only attributes and DEVICE_ATTR_RW for read/write attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall [groeck: Update description] Signed-off-by: Guenter Roeck

hwmon: (lm85) Fix overflows seen when writing voltage limit attributes

2016-12-12T19:33:43+00:00

Writes into voltage limit attributes can overflow due to an unbound multiplication. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm85) use find_closest() in x_TO_REG() functions

2015-04-17T13:03:55+00:00

Replace RANGE_TO_REG() and FREQ_TO_REG() implementations with calls to find_closest(). Signed-off-by: Bartosz Golaszewski Cc: Guenter Roeck Cc: Steven Rostedt Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

hwmon: (lm85) Convert to devm_hwmon_device_register_with_groups

2014-08-04T14:01:41+00:00

Use devm_hwmon_device_register_with_groups() to simplify the code a bit. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: (lm85) Avoid forward declaration

2014-08-04T14:01:40+00:00

Reorder functions to avoid forward declaration. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: (lm85) Fix various errors on attribute writes

2014-07-31T04:42:33+00:00

Temperature limit register writes did not account for negative numbers. As a result, writing -127000 resulted in -126000 written into the temperature limit register. This problem affected temp[1-3]_min, temp[1-3]_max, temp[1-3]_auto_temp_crit, and temp[1-3]_auto_temp_min. When writing pwm[1-3]_freq, a long variable was auto-converted into an int without range check. Wiring values larger than MAXINT resulted in unexpected register values. When writing temp[1-3]_auto_temp_max, an unsigned long variable was auto-converted into an int without range check. Writing values larger than MAXINT resulted in unexpected register values. vrm is an u8, so the written value needs to be limited to [0, 255]. Cc: Axel Lin Cc: stable@vger.kernel.org Reviewed-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: (lm85) Drop generic detection

2014-06-12T15:36:30+00:00

Generic detection leads to too many false positives, so drop it. FWIW sensors-detect does not have such generic detection. If the user wants to force the driver to bind to a not yet supported chip, he/she can still do so using sysfs attribute new_device. Signed-off-by: Jean Delvare Signed-off-by: Guenter Roeck

Update Jean Delvare's e-mail address

2014-01-29T19:40:08+00:00

Signed-off-by: Jean Delvare

hwmon: Fix checkpatch warning 'quoted string split across lines'

2013-04-08T04:16:40+00:00

Cc: Corentin Labbe Cc: Mark M. Hoffman Cc: Fenghua Yu Cc: Juerg Haefliger Cc: Andreas Herrmann Cc: Rudolf Marek Cc: Jim Cromie Cc: Roger Lucas Cc: Marc Hulsman Signed-off-by: Guenter Roeck