kernel/linux.git/drivers/hwmon/lm80.c, branch linux-4.4.y

Revert "hwmon: (lm80) fix a missing check of bus read in lm80 probe"

2021-05-26T09:27:32+00:00

commit 99ae3417672a6d4a3bf68d4fc43d7c6ca074d477 upstream. This reverts commit 9aa3aa15f4c2f74f47afd6c5db4b420fadf3f315. Because of recent interactions with developers from @umn.edu, all commits from them have been recently re-reviewed to ensure if they were correct or not. Upon review, it was determined that this commit is not needed at all so just revert it. Also, the call to lm80_init_client() was not properly handled, so if error handling is needed in the lm80_probe() function, then it should be done properly, not half-baked like the commit being reverted here did. Cc: Kangjie Lu Fixes: 9aa3aa15f4c2 ("hwmon: (lm80) fix a missing check of bus read in lm80 probe") Cc: stable Acked-by: Guenter Roeck Link: https://lore.kernel.org/r/20210503115736.2104747-5-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman

hwmon: (lm80) Fix missing unlock on error in set_fan_div()

2019-02-23T08:05:13+00:00

[ Upstream commit 07bd14ccc3049f9c0147a91a4227a571f981601a ] Add the missing unlock before return from function set_fan_div() in the error handling case. Fixes: c9c63915519b ("hwmon: (lm80) fix a missing check of the status of SMBus read") Signed-off-by: Wei Yongjun Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin

hwmon: (lm80) fix a missing check of bus read in lm80 probe

2019-02-20T09:13:12+00:00

[ Upstream commit 9aa3aa15f4c2f74f47afd6c5db4b420fadf3f315 ] In lm80_probe(), if lm80_read_value() fails, it returns a negative error number which is stored to data->fan[f_min] and will be further used. We should avoid using the data if the read fails. The fix checks if lm80_read_value() fails, and if so, returns with the error number. Signed-off-by: Kangjie Lu Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin

hwmon: (lm80) fix a missing check of the status of SMBus read

2019-02-20T09:13:12+00:00

[ Upstream commit c9c63915519b1def7043b184680f33c24cd49d7b ] If lm80_read_value() fails, it returns a negative number instead of the correct read data. Therefore, we should avoid using the data if it fails. The fix checks if lm80_read_value() fails, and if so, returns with the error number. Signed-off-by: Kangjie Lu [groeck: One variable for return values is enough] Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin

hwmon: (lm80) Rearrange code to avoid forward declarations

2014-05-21T23:02:26+00:00

Avoid need for forward declarations by rearranging code. No functional change. Signed-off-by: Guenter Roeck

hwmon: (lm80) Convert fan display function macros into functions

2014-05-21T23:02:26+00:00

Convert fan display function macros into functions to reduce code size and improve code readability. Code size reduction is about 200 bytes on x86_64. Signed-off-by: Guenter Roeck

hwmon: (lm80) Convert voltage display function macros into functions

2014-05-21T23:02:26+00:00

Convert voltage display function macros into functions to reduce code size and improve code readability. Code size reduction is about 600 bytes on x86_64. Signed-off-by: Guenter Roeck

hwmon: (lm80) Convert temperature display function macros into functions

2014-05-21T23:02:26+00:00

Convert temperature display function macros into functions to reduce code size and improve code readability. Code size reduction is about 2k on x86_64. Signed-off-by: Guenter Roeck

hwmon: (lm80) Normalize all temperature values to 16 bit

2014-05-21T23:02:26+00:00

Normalize all stored temperature values to 16 bit to simplify temperature calculations. Signed-off-by: Guenter Roeck

hwmon: (lm80) Simplify TEMP_FROM_REG

2014-05-21T23:02:26+00:00

TEMP_FROM_REG gets 12 bits of temperature data in the upper 12 bit of a signed 16 bit parameter, with the integer part (including sign) in the upper 8 bit and the remainder in bit 4..7. The lower 4 bit of the 16 bit data is always 0. We can use that information to convert the temperature directly into display data (1/1000th of degree C). Note that the stored temperature data is not shifted right as the comment claimed, so remove that misleading comment. Signed-off-by: Guenter Roeck