kernel/linux.git/drivers/hwmon/lm77.c, branch linux-4.7.y

hwmon: (lm77) Prevent overflow problem when writing large limits

2014-07-31T16:41:46+00:00

On platforms with sizeof(int) < sizeof(long), writing a temperature limit larger than MAXINT will result in unpredictable limit values written to the chip. Clamp the input values to the supported limits first to fix the problem. For set_temp_hyst: As Guenter pointed out that the temperature is read as unsigned and stored in an unsigned long. This is wrong; nothing in the datasheet suggests that the value (the absolute temperature) must be positive. So change it to signed. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: (lm77) Convert to use devm_hwmon_device_register_with_groups

2014-05-21T23:02:21+00:00

Use devm_hwmon_device_register_with_groups API to attach attributes to hwmon device, simplify code, and reduce code size. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm77) Drop function macros

2014-05-21T23:02:20+00:00

Function macros make the code harder to read and increase code size, so drop them. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm77) Do not preserve hysteresis when updating critical temp limit

2014-05-21T23:02:20+00:00

Updating the hysteresis value when updating the critical temperature limit was following the rule of 'least surprise'. However, it had the undesirable side effect of changing the hysteresis for all other attributes, which defeats the purpose of least surprise. In addition, it could result in invalid hysteresis values if the resulting hysteresis was too large. In such cases the resulting hysteresis ended up changed anyway, which again defeats the purpose. So drop that code and document the new behavior. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm77) Rearrange code to no longer require forward declarations

2014-05-21T23:02:20+00:00

Forward declarations are easy to avoid and unnecessary. Rearrange code to avoid it. No functional change. Acked-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (lm77) Drop FSF mailing address

2014-05-21T23:02:20+00:00

The FSF mailing address changes over time, so drop it. No functional change. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: Avoid initializing the same field twice

2014-04-04T16:01:34+00:00

All hwmon drivers allocate their data structure with some form of kzalloc, so setting data fields to zero explicitly is a waste of time. Signed-off-by: Jean Delvare Reviewed-by: Guenter Roeck

hwmon: Replace SENSORS_LIMIT with clamp_val

2013-01-26T05:03:54+00:00

SENSORS_LIMIT and the generic clamp_val have the same functionality, and clamp_val is more efficient. This patch reduces text size by 9052 bytes and bss size by 11624 bytes for x86_64 builds. Signed-off-by: Guenter Roeck Acked-by: George Joseph Acked-by: Jean Delvare

hwmon: (lm77) Convert to use devm_ functions

2012-07-22T04:48:40+00:00

Convert to use devm_ functions to reduce code size and simplify the code. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare

hwmon: (lm77) Improve code readability

2012-07-22T04:48:40+00:00

Rename new_client variable, and define new variable for client->dev. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare