kernel/linux.git/drivers/hwmon/lm63.c, branch linux-4.4.y

hwmon: (lm63) Fix smatch warnings

2014-08-04T14:01:36+00:00

smatch complains as follows when checking lm63.c. drivers/hwmon/lm63.c:594 set_temp11() warn: '65504' 65504 can't fit into 32767 'data->temp11[nr]' drivers/hwmon/lm63.c:596 set_temp11() warn: '32768' 32768 can't fit into 32767 'data->temp11[nr]' Fix by using DIV_ROUND_CLOSEST and clamp_val to convert the values. While we are at it, modify other macros as well for consistency and to make the code easier to understand. Signed-off-by: Guenter Roeck

hwmon: (lm63) Avoid initializing the same field twice

2014-04-04T16:01:33+00:00

data is kzalloc'd, so data->valid is already 0. Signed-off-by: Jean Delvare Reviewed-by: Guenter Roeck

hwmon: (lm63) Convert to use devm_hwmon_device_register_with_groups

2014-04-04T16:01:33+00:00

Simplify code, reduce code size, attach hwmon attributes to hwmon device. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

hwmon: (lm63) Create all sysfs groups in one call

2014-04-04T16:01:33+00:00

We can create all sysfs groups in one call by using sysfs_create_groups instead of using sysfs_create_group individually for each group. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

hwmon: (lm63) Introduce 'dev' variable to point to client->dev

2014-04-04T16:01:33+00:00

client->dev is used multiple times in several functions. Introduce dev variable pointing to it to simplify the code. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

hwmon: (lm63) Add additional sysfs group for temp2_type attribute

2014-04-04T16:01:32+00:00

With the new hwmon API, we can only add groups of attributes, not individual attributes. To prepare for the use of the new API, add an additional sensor group for the temp2_type attribute and register it with sysfs_create_group instead of device_create_file. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

Update Jean Delvare's e-mail address

2014-01-29T19:40:08+00:00

Signed-off-by: Jean Delvare

hwmon: (lm63) Drop redundant safety on cache lifetime

2013-07-08T12:18:24+00:00

time_after (as opposed to time_after_equal) already ensures that the cache lifetime is at least as much as requested. There is no point in manually adding another jiffy to that value, and this can confuse the reader into wrong interpretation. Signed-off-by: Jean Delvare Cc: Imre Deak

hwmon: Replace SENSORS_LIMIT with clamp_val

2013-01-26T05:03:54+00:00

SENSORS_LIMIT and the generic clamp_val have the same functionality, and clamp_val is more efficient. This patch reduces text size by 9052 bytes and bss size by 11624 bytes for x86_64 builds. Signed-off-by: Guenter Roeck Acked-by: George Joseph Acked-by: Jean Delvare

hwmon: (lm63) Convert to use devm_ functions

2012-07-22T04:48:40+00:00

Convert to use devm_ functions to reduce code size and simplify the code. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare