kernel/linux.git/drivers/hwmon/lm63.c, branch linux-4.16.y

hwmon: (lm63) Add OF device ID table

2017-04-02T14:01:53+00:00

The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas Signed-off-by: Guenter Roeck

hwmon: (lm63) use permission-specific DEVICE_ATTR variants

2017-01-02T18:19:45+00:00

Use DEVICE_ATTR_RO for read only attributes and DEVICE_ATTR_RW for read/write attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall [groeck: Updated description] Signed-off-by: Guenter Roeck

hwmon: (lm63) Fix smatch warnings

2014-08-04T14:01:36+00:00

smatch complains as follows when checking lm63.c. drivers/hwmon/lm63.c:594 set_temp11() warn: '65504' 65504 can't fit into 32767 'data->temp11[nr]' drivers/hwmon/lm63.c:596 set_temp11() warn: '32768' 32768 can't fit into 32767 'data->temp11[nr]' Fix by using DIV_ROUND_CLOSEST and clamp_val to convert the values. While we are at it, modify other macros as well for consistency and to make the code easier to understand. Signed-off-by: Guenter Roeck

hwmon: (lm63) Avoid initializing the same field twice

2014-04-04T16:01:33+00:00

data is kzalloc'd, so data->valid is already 0. Signed-off-by: Jean Delvare Reviewed-by: Guenter Roeck

hwmon: (lm63) Convert to use devm_hwmon_device_register_with_groups

2014-04-04T16:01:33+00:00

Simplify code, reduce code size, attach hwmon attributes to hwmon device. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

hwmon: (lm63) Create all sysfs groups in one call

2014-04-04T16:01:33+00:00

We can create all sysfs groups in one call by using sysfs_create_groups instead of using sysfs_create_group individually for each group. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

hwmon: (lm63) Introduce 'dev' variable to point to client->dev

2014-04-04T16:01:33+00:00

client->dev is used multiple times in several functions. Introduce dev variable pointing to it to simplify the code. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

hwmon: (lm63) Add additional sysfs group for temp2_type attribute

2014-04-04T16:01:32+00:00

With the new hwmon API, we can only add groups of attributes, not individual attributes. To prepare for the use of the new API, add an additional sensor group for the temp2_type attribute and register it with sysfs_create_group instead of device_create_file. Signed-off-by: Guenter Roeck Signed-off-by: Jean Delvare

Update Jean Delvare's e-mail address

2014-01-29T19:40:08+00:00

Signed-off-by: Jean Delvare

hwmon: (lm63) Drop redundant safety on cache lifetime

2013-07-08T12:18:24+00:00

time_after (as opposed to time_after_equal) already ensures that the cache lifetime is at least as much as requested. There is no point in manually adding another jiffy to that value, and this can confuse the reader into wrong interpretation. Signed-off-by: Jean Delvare Cc: Imre Deak