kernel/linux.git/drivers/hwmon/atxp1.c, branch linux-4.16.y

hwmon: (atxp1) use permission-specific DEVICE_ATTR variants

2017-01-02T18:19:45+00:00

Use DEVICE_ATTR_RW for read/write attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall [groeck: Updated description] Signed-off-by: Guenter Roeck

hwmon: (atxp1) Drop auto-detection

2015-06-01T05:58:36+00:00

Auto-detection for this chip is highly unreliable, and one of its I2C addresses can also be used by EEPROMs, increasing the risk for false positives even more. Drop auto-detection entirely to remove the risk. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (atxp1) Drop FSF mailing address

2015-06-01T05:58:36+00:00

The FSF mailing address may change and does not provide any real value. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (atxp1) Convert to devm_hwmon_device_register_with_groups

2014-08-04T14:01:33+00:00

Use ATTRIBUTE_GROUPS macro and devm_hwmon_device_register_with_groups. This simplifies the code a bit. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: (atxp1) Avoid forward declaration

2014-06-12T15:36:49+00:00

Move atxp1_id and atxp1_driver to proper place to avoid forward declaration. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: Avoid initializing the same field twice

2014-04-04T16:01:34+00:00

All hwmon drivers allocate their data structure with some form of kzalloc, so setting data fields to zero explicitly is a waste of time. Signed-off-by: Jean Delvare Reviewed-by: Guenter Roeck

hwmon: (atxp1) Set and use error code from vid_to_reg()

2013-10-13T23:16:26+00:00

vid_to_reg() returns -1 if it encounters an error. Return -EINVAL instead. Its only caller, atxp1_storevcore(), doesn't use the return code but returns -1 instead, which is wrong anyway as it means -EPERM. Use the return value from vid_to_reg() instead to report the error. Signed-off-by: Guenter Roeck Reviewed-by: Jean Delvare

hwmon: (atxp1) Convert to use devm_ functions

2012-07-22T04:48:39+00:00

Convert to use devm_ functions to reduce code size and simplify the code. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare

hwmon: (atxp1) Fix checkpatch issues

2012-03-19T01:27:03+00:00

Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: else should follow close brace '}' ERROR: "foo * bar" should be "foo *bar" WARNING: braces {} are not necessary for single statement blocks WARNING: line over 80 characters WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Sebastian Witt Signed-off-by: Guenter Roeck

hwmon: convert drivers/hwmon/* to use module_i2c_driver()

2012-03-19T01:26:50+00:00

This patch converts the drivers in drivers/hwmon/* to use the module_i2c_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Axel Lin Cc: Corentin Labbe Cc: Dirk Eibach Cc: "Mark M. Hoffman" Cc: Steve Glendinning Cc: Riku Voipio Cc: Guillaume Ligneul Cc: David George Cc: "Hans J. Koch" Cc: Marc Hulsman Cc: Rudolf Marek Signed-off-by: Guenter Roeck