kernel/linux.git/drivers/gpu/nova-core/bitfield.rs, branch linux-7.0.yLinux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=linux-7.0.y2026-05-23T11:08:53+00:00gpu: nova-core: bitfield: fix broken Default implementation2026-05-23T11:08:53+00:00Eliot Courtneyecourtney@nvidia.com2026-04-01T01:42:28+00:00urn:sha1:c55c8ea5c2a3d80d99f2a1361dba571e17b0a74b
[ Upstream commit de0aca13509bf47a2d49bc7a26d56079c758c95f ]
The current implementation does not actually set the default values for
the fields in the bitfield.
Fixes: 3fa145bef533 ("gpu: nova-core: register: generate correct `Default` implementation")
Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
Link: https://patch.msgid.link/20260401-fix-bitfield-v2-1-2fa68c98114a@nvidia.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
gpu: nova-core: bitfield: remove BitOr implementation2025-10-25T04:16:31+00:00Alexandre Courbotacourbot@nvidia.com2025-10-22T10:50:58+00:00urn:sha1:ca16b15e78f4dee1631c0a68693f5e7d9b3bb3ec
Using this operand can produce invalid values. It also doesn't bring
any benefit as one can use the builder pattern to assemble a new value.
Reported-by: Edwin Peer <epeer@nvidia.com>
Link: https://lore.kernel.org/rust-for-linux/F3853912-2C1C-4F9B-89B0-3168689F35B3@nvidia.com/
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251022-nova-bitfield-v1-3-73bc0988667b@nvidia.com>
gpu: nova-core: bitfield: simplify expression2025-10-25T04:16:31+00:00Alexandre Courbotacourbot@nvidia.com2025-10-22T10:50:57+00:00urn:sha1:e6b8932b9374bd0591bb4dda3eb3e4f1cc50655e
The shift is more easily expressed by the index of the lowest bit of the
field.
Reported-by: Edwin Peer <epeer@nvidia.com>
Link: https://lore.kernel.org/rust-for-linux/F3853912-2C1C-4F9B-89B0-3168689F35B3@nvidia.com/
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251022-nova-bitfield-v1-2-73bc0988667b@nvidia.com>
gpu: nova-core: bitfield: simplify condition2025-10-25T04:16:31+00:00Alexandre Courbotacourbot@nvidia.com2025-10-22T10:50:56+00:00urn:sha1:fa08ec789f81425c3722fd2c6df825e06c810b43
This condition was uselessly convoluted.
Reported-by: Edwin Peer <epeer@nvidia.com>
Link: https://lore.kernel.org/rust-for-linux/F3853912-2C1C-4F9B-89B0-3168689F35B3@nvidia.com/
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251022-nova-bitfield-v1-1-73bc0988667b@nvidia.com>
gpu: nova-core: bitfield: Add support for custom visibility2025-10-21T13:40:00+00:00Joel Fernandesjoelagnelf@nvidia.com2025-10-16T15:13:23+00:00urn:sha1:77ed4376d7c5de8be1f2612d6b4777077fb5fdb2
Add support for custom visibility to allow for users to control
visibility of the structure and helpers.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Elle Rhumsaa <elle@weathered-steel.dev>
Reviewed-by: Edwin Peer <epeer@nvidia.com>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
[acourbot@nvidia.com: fix long lines warnings and typo in commit message.]
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251016151323.1201196-5-joelagnelf@nvidia.com>
gpu: nova-core: bitfield: Add support for different storage widths2025-10-21T13:39:44+00:00Joel Fernandesjoelagnelf@nvidia.com2025-10-16T15:13:22+00:00urn:sha1:7cabacb1aad647931980f63fa18292ad3f859544
Previously, bitfields were hardcoded to use u32 as the underlying
storage type. Add support for different storage types (u8, u16, u32,
u64) to the bitfield macro.
New syntax is: struct Name(<type ex., u32>) { ... }
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Elle Rhumsaa <elle@weathered-steel.dev>
Reviewed-by: Edwin Peer <epeer@nvidia.com>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
[acourbot@nvidia.com: fix long lines warnings.]
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251016151323.1201196-4-joelagnelf@nvidia.com>
gpu: nova-core: bitfield: Move bitfield-specific code from register! into new macro2025-10-21T13:38:57+00:00Joel Fernandesjoelagnelf@nvidia.com2025-10-16T15:13:21+00:00urn:sha1:71ea85be25b4f54a53ec03d5deaed52f5ee65da8
Move the bitfield-specific code from the register macro into a new macro
called bitfield. This will be used to define structs with bitfields,
similar to C language.
Reviewed-by: Elle Rhumsaa <elle@weathered-steel.dev>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Edwin Peer <epeer@nvidia.com>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251016151323.1201196-3-joelagnelf@nvidia.com>