kernel/linux.git/drivers/gpu/drm/udl, branch v6.18.21

drm/udl: Set error code in udl_init()

2025-04-17T08:21:40+00:00

Return -ENOMEM if udl_alloc_urb_list() fails. Don't return success. Fixes: fb10144ba426 ("drm/udl: Support adapters without firmware descriptor") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann Signed-off-by: Thomas Zimmermann Link: https://lore.kernel.org/r/Z_-P4N4_U-xTC9-O@stanley.mountain

drm/udl: Support adapters without firmware descriptor

2025-04-14T08:19:21+00:00

Set default limit on the number of pixels for adapters without vendor firmware descriptor. The devices work as expected, they just don't provide any description. If parsing the vendor firmware descriptor fails, the device falls back to the given default limits. Failing to allocate memory is still an error. v2: - fix typo in constant (Patrik) Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-10-tzimmermann@suse.de

drm/udl: Validate length in vendor-descriptor parser

2025-04-14T08:19:20+00:00

Rewrite the parser for the vendor firmware descriptor with the following improvements. - Validate the key-value length given in a vendor descriptor against the length of the descriptor. The current code fails to do this and might read more bytes than available. This can lead to out-of-bounds reads of the allocated buffer. - Read raw data with helpers for unaligned data. This allows the code to run on platforms that do now support unaligned memory access by default. - Validate the pixel limit against a default value. The default comes from real-world devices. If the reported number of pixels is significantly above the limit, it is likely invalid. - Drop the obsolete print macros. There is still a warning about invalid firmware descriptors. The rest of the output is bogus. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-9-tzimmermann@suse.de

drm/udl: Treat vendor descriptor as u8

2025-04-14T08:19:20+00:00

The vendor descriptor is an array of unsigned bytes. It is raw data that is not to be modified. Declare it as 'const u8'. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-8-tzimmermann@suse.de

drm/udl: Return error if vendor descriptor is too short

2025-04-14T08:19:19+00:00

There need to be least 5 bytes in the vendor descriptor. Return an error otherwise. Also change the branching to early-out on the error. Adjust indention of the rest of the parser function. The original length test expected more than 5 bytes in the vendor descriptor. As a descriptor with no key-value pairs has exactly 5 bytes and is still valid, change the test to accept this case as well. v2 - clarify changes to length test in commit description (Patrik) Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-7-tzimmermann@suse.de

drm/udl: Handle errors from usb_get_descriptor()

2025-04-14T08:19:19+00:00

Reading the vendor descriptor from the udl device can fail with an error, which the current code fails to capture. Store the return value in an integer and test for the error. Abort parsing on errors or treat the value as length on success. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-6-tzimmermann@suse.de

drm/udl: The number of pixels is always positive

2025-04-14T08:19:18+00:00

Store sku_pixel_limit as type unsigned long instead of int. The number of pixels available is always positive. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-5-tzimmermann@suse.de

drm/udl: Improve type safety when using struct udl_device

2025-04-14T08:19:18+00:00

Push upcasts from struct drm_device to struct udl_device outwards in the call chain; cast earlier and call functions with the upcasted value. Improves type safety. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-4-tzimmermann@suse.de

drm/udl: Remove unused field gem_lock from struct udl_device

2025-04-14T08:19:17+00:00

Reduce the size of struct udl_device by removing the unused field gem_lock. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-3-tzimmermann@suse.de

drm/udl: Remove unused field dev from struct udl_device

2025-04-14T08:19:17+00:00

Reduce the size of struct udl_device by removing the unused field dev. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250410105948.25463-2-tzimmermann@suse.de