kernel/linux.git/drivers/gpu/drm/tilcdc/tilcdc_drv.c, branch linux-4.7.y

drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data

2016-02-25T14:39:47+00:00

Use devm_kzalloc() and devm_kcalloc() for private data allocation at driver load time. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen

drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts

2016-02-25T14:39:44+00:00

Add ratelimited prints on sync lost and FIFO underrun interrupts. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen

drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[]

2016-02-25T14:39:43+00:00

Removes the duplicate LCDC_INT_ENABLE_SET_REG-entry in registers array. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen

drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc

2016-02-25T14:39:42+00:00

Fix interrupt enable/disable code for version 2 tilcdc. In version 2 tilcdc there is a separate register for disabling interrupts. Writing 0 to enable registers bits does not have any effect. The interrupt clear register works the same way, writing 1 to specific bit disables the interrupt and writing 0 does not have any effect. The "bug" that is fixed here does not really do any harm since the interrupts are enabled only once in the power up and disabled before power down. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen

drm/tilcdc: Get rid of complex ping-pong mechanism

2016-02-25T14:39:40+00:00

Get rid of complex ping-pong mechanism and replace it with simpler single buffer flipping code. The LCDC HW appears to be designed mainly static framebuffers in mind. There are two modes of operation, either static single buffer, or ping pong double buffering with two static buffers switching back and forth. Luckily the framebuffer start address is fetched only in the beginning of the frame and changing the address after that only takes effect after the next vertical blank. The page flipping code can simply write the address of the new framebuffer and the page is flipped automatically after the next vertical blank. Using the ping pong double buffering makes the flipping code way more complex and it does not provide any benefit, so it is better to switch to single buffer operation. There is still one problem in updating the framebuffer dma address on the fly. There are two registers defining the framebuffer dma area and things may break if the dma address is fetched in while the registers are are being updated. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha

drm/tilcdc: disable crtc on unload

2016-02-25T14:39:37+00:00

Disable crtc on unload. Call tilcdc_crtc_dpms() with DRM_MODE_DPMS_OFF in the beginning of unload function. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha

drm/tilcdc: cleanup runtime PM handling

2016-02-25T14:39:36+00:00

Cleanup runtime PM handling. Before the patch the usage of pm_runtime calls was inconsistent and hard to follow. After the update the pm_runtime calls are removed from set_scanout() and called around major operations that access the HW. After the patch the DPMS code does not have pm_runtime_forbid/allow calls any more and pm_runtime_irq_safe() is not set anymore. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha

drm/tilcdc: Allocate register storage based on the actual number registers

2016-02-25T14:39:35+00:00

Allocate suspend/resume register storage based on the actual number registers the driver is aware of. The static allocation for register storage had fallen behind badly. Reported-by: Michael Bode Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen

drm/tilcdc: fix build error when !CONFIG_CPU_FREQ

2016-02-25T14:39:34+00:00

Fix build error when !CONFIG_CPU_FREQ drivers/gpu/drm/tilcdc/tilcdc_drv.c: In function 'tilcdc_load': drivers/gpu/drm/tilcdc/tilcdc_drv.c:327:1: error: label 'fail_put_clk' defined but not used [-Werror=unused-label] fail_put_clk: ^ Signed-off-by: Grygorii Strashko Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen

drm/tilcdc: Implement dma-buf support for tilcdc

2016-02-25T14:39:33+00:00

There is nothing special about tilcdc HW when the video memory is concerned. Just using the standard drm helpers for implementation is enough. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen