kernel/linux.git/drivers/gpu/drm/imx/parallel-display.c, branch v5.19

drm/imx: Fix memory leak in imx_pd_connector_get_modes

2022-04-04T07:37:42+00:00

Avoid leaking the display mode variable if of_get_drm_display_mode fails. Fixes: 76ecd9c9fb24 ("drm/imx: parallel-display: check return code from of_get_drm_display_mode()") Addresses-Coverity-ID: 1443943 ("Resource leak") Signed-off-by: José Expósito Signed-off-by: Philipp Zabel Link: https://lore.kernel.org/r/20220108165230.44610-1-jose.exposito89@gmail.com

drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check()

2022-03-16T15:35:04+00:00

If display timings were read from the devicetree using of_get_display_timing() and pixelclk-active is defined there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is automatically generated. Through the function drm_bus_flags_from_videomode() e.g. called in the panel-simple driver this flag got into the bus flags, but then in imx_pd_bridge_atomic_check() the bus flag check failed and will not initialize the display. The original commit fe141cedc433 does not explain why this check was introduced. So remove the bus flags check, because it stops the initialization of the display with valid bus flags. Fixes: fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available") Signed-off-by: Christoph Niedermaier Cc: Marek Vasut Cc: Boris Brezillon Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org To: dri-devel@lists.freedesktop.org Tested-by: Max Krummenacher Acked-by: Boris Brezillon Signed-off-by: Marek Vasut Link: https://patchwork.freedesktop.org/patch/msgid/20220201113643.4638-1-cniedermaier@dh-electronics.com Signed-off-by: Maarten Lankhorst

drm/bridge: Centralize error message when bridge attach fails

2021-07-28T13:33:12+00:00

Being informed of a failure to attach a bridge is useful, and many drivers prints an error message in that case. Move the message to drm_bridge_attach() to avoid code duplication. Suggested-by: Stephen Boyd Signed-off-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen Reviewed-by: Jyri Sarha

drm/imx: parallel-display: use drm managed resources

2021-01-04T11:59:34+00:00

Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter

drm/imx: parallel-display: move initialization into probe

2021-01-04T11:59:33+00:00

Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter

drm/imx: parallel-display: use local bridge and connector variables

2021-01-04T11:59:33+00:00

Use local variables for bridge and connector. This simplifies the following commits. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter

gpu: drm: imx: convert comma to semicolon

2021-01-04T11:54:18+00:00

Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun Signed-off-by: Philipp Zabel

drm/imx: parallel-display: reduce scope of edid_len

2020-10-27T09:20:36+00:00

The edid_len variable is never used again. Use a local variable instead of storing it in the device structure. Signed-off-by: Philipp Zabel

drm/imx: parallel-display: remove unused function enc_to_imxpd()

2020-10-27T09:20:36+00:00

Remove leftover container_of helper, it has been replaced by bridge_to_imxpd(). Fixes: fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available") Signed-off-by: Philipp Zabel

drm/imx: parallel-display: fix edid memory leak

2020-10-27T09:20:36+00:00

The edid memory is only freed if the component.unbind() is called. This is okay if the parallel-display was bound but if the bind() fails we leak the memory. Signed-off-by: Marco Felsch [p.zabel@pengutronix.de: rebased, dropped now empty unbind()] Signed-off-by: Philipp Zabel