kernel/linux.git/drivers/gpu/drm/i915/intel_clock_gating.c, branch linux-7.0.yLinux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=linux-7.0.y2025-11-25T14:32:10+00:00drm/i915: use struct drm_device for clock gating funcs2025-11-25T14:32:10+00:00Jani Nikulajani.nikula@intel.com2025-11-21T11:22:00+00:00urn:sha1:0a9231590f16f596541154f43375f3e2c419a3ef
While we want to refactor intel_clock_gating.[ch] and likely move a lot
of display related code to display, start off with a little intermediate
change to use struct drm_device in the interface instead of struct
drm_i915_private, to allow us to drop another dependency on i915_drv.h
and struct drm_i915_private.
Cc: Luca Coelho <luciano.coelho@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Link: https://patch.msgid.link/20251121112200.3435099-2-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drm: include drm_print.h where needed2025-10-31T08:34:52+00:00Jani Nikulajani.nikula@intel.com2025-10-29T10:39:45+00:00urn:sha1:f6e8dc9edf963dbc99085e54f6ced6da9daa6100
There are a gazillion files that depend on drm_print.h being indirectly
included via drm_buddy.h, drm_mm.h, or ttm/ttm_resource.h. In
preparation for removing those includes, explicitly include drm_print.h
where needed.
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://lore.kernel.org/r/5fe67395907be33eb5199ea6d540e29fddee71c8.1761734313.git.jani.nikula@intel.com
drm/i915/reg: separate VLV_DSPCLK_GATE_D from DSPCLK_GATE_D2025-08-14T10:12:23+00:00Jani Nikulajani.nikula@intel.com2025-08-06T16:55:15+00:00urn:sha1:7e757092373ccf147e23f46d1167718680db8ec6
All the places that use DSPCLK_GATE_D are specific to certain platforms,
and the parametrization of it to support VLV/CHV MMIO display base isn't
really buying us anything. Add a separate macro for VLV_DSPCLK_GATE_D
and use it.
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/ac16d9d5192595944bf9bcf70aa721b504bc90c0.1754499175.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drm/i915/clockgating: pass display to DSPCNTR and DSPSURF register macros2025-08-14T10:12:22+00:00Jani Nikulajani.nikula@intel.com2025-08-06T16:55:06+00:00urn:sha1:0418dfd86144662bae9360e8c7899cf928bbf04e
Underneath, the macros expect struct intel_display. Switch to it in
preparation for removing the transitional __to_intel_display() macro.
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/014410b59845b401950faff992540ea9b32ac213.1754499175.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drm/i915/clockgating: pass display to HAS_PCH_*() macros2025-08-14T10:12:22+00:00Jani Nikulajani.nikula@intel.com2025-08-06T16:55:05+00:00urn:sha1:077ad673d986c041f43aadf57e5ca5829a36ffc9
Underneath, the HAS_PCH_*() macros expect struct intel_display. Switch
to it in preparation for removing the transitional __to_intel_display()
macro.
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/824750abaf4587501d61dce964b36542d93931f7.1754499175.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drm/i915/clockgating: pass display to for_each_pipe()2025-08-14T10:12:22+00:00Jani Nikulajani.nikula@intel.com2025-08-06T16:55:04+00:00urn:sha1:3a28f5c19d4d555363aeb99986bb3761d1cc29a4
Underneath, for_each_pipe() really expects struct intel_display. Switch
to it in preparation for removing the transitional __to_intel_display()
macro.
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/1abcd9b4429a25eb40c30691c876d3db089b1cf2.1754499175.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drm/i915: stop including display/intel_display_{core, limits}.h from i915_drv.h2025-05-27T08:25:53+00:00Jani Nikulajani.nikula@intel.com2025-05-22T09:48:43+00:00urn:sha1:62384da2a04d7a61d840ad099fc9d0d065b31208
Make i915->display pointer opaque to most of core i915 driver. Lots of
places now need explicit include of intel_display_core.h, or a more
specific header.
With this dependency broken, changes in display should cause radically
less recompilation of i915.
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Link: https://lore.kernel.org/r/b381b59acb7e4f600e0282935a68aedf77768109.1747907216.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drm/{i915,xe}: convert i915 and xe display members into pointers2025-05-16T08:15:16+00:00Jani Nikulajani.nikula@intel.com2025-05-07T15:22:54+00:00urn:sha1:96b451d53ae9760858c547081532b01038f00912
As the first step towards making struct intel_display an opaque pointer
in i915 and xe drivers, convert the struct drm_i915_private and struct
xe_device display members into pointers.
Initially, add temporary struct intel_display __display members, and
point display at it to avoid dynamic allocation. In the future, we can
drop this, and switch to dynamic allocation.
The conversion is done simply with sed:
sed -i 's/&\([a-zA-Z0-9_>.-]*\)\(dev_priv\|i915\|xe\)->display\([^.]\)/\1\2->display\3/g' \
$(git ls-files -- drivers/gpu/drm/i915 drivers/gpu/drm/xe)
sed -i 's/\(dev_priv\|i915\|xe\)->display\./\1->display->/g' \
$(git ls-files -- drivers/gpu/drm/i915 drivers/gpu/drm/xe)
With a couple of manual tweaks on top.
v2: Initialize i915->display also in selftest mock_gem_device()
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://lore.kernel.org/r/20250507152254.2398934-1-jani.nikula@intel.com
drm/i915: do not reference i915->display inline2025-05-16T08:15:12+00:00Jani Nikulajani.nikula@intel.com2025-05-07T09:38:35+00:00urn:sha1:702f530a647f00cf5730cfc88e4cd0e699f22351
Always use a local variable for display instead of referencing
i915->display inline. This makes it easier to convert i915->display into
a pointer.
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://lore.kernel.org/r/afcf305e8c4ea452cee37479530958f36a10c840.1746610601.git.jani.nikula@intel.com
drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch]2025-05-13T07:26:44+00:00Jani Nikulajani.nikula@intel.com2025-05-12T14:56:52+00:00urn:sha1:6819b5a67e7014352906f82ddedafb602ac8d45d
Be more specific in the naming, and follow the existing function naming
pattern of vlv_iosf_sb_*() in the file.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/d3d97d34a197ba801c558c3fd72b29f9e5c783af.1747061743.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>