Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v5.18 2022-04-27T21:38:02+00:00 2022-04-27T21:38:02+00:00 Evan Quan evan.quan@amd.com 2022-04-08T11:51:34+00:00 urn:sha1:a71849cdeaec4579696e5e1c45d9279f7b7484bd The adev->pm.mutx is already held at the beginning of amdgpu_dpm_compute_clocks/amdgpu_dpm_enable_uvd/amdgpu_dpm_enable_vce. But on their calling path, amdgpu_display_bandwidth_update will be called and thus its sub functions amdgpu_dpm_get_sclk/mclk. They will then try to acquire the same adev->pm.mutex and deadlock will occur. By placing amdgpu_display_bandwidth_update outside of adev->pm.mutex protection(considering logically they do not need such protection) and restructuring the call flow accordingly, we can eliminate the deadlock issue. This comes with no real logics change. Fixes: 3712e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c") Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> Reported-by: Arthur Marsh <arthur.marsh@internode.on.net> Link: https://lore.kernel.org/all/9e689fea-6c69-f4b0-8dee-32c4cf7d8f9c@molgen.mpg.de/ BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1957 Signed-off-by: Evan Quan <evan.quan@amd.com> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-04-06T16:02:57+00:00 Alex Deucher alexander.deucher@amd.com 2022-03-25T15:53:39+00:00 urn:sha1:ebc002e3ee78409c42156e62e4e27ad1d09c5a75 Seems to cause a reboots or hangs on some systems. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1924 Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1953 Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)") Reviewed-by: Lijo Lazar <lijo.lazar@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org 2022-03-25T16:40:24+00:00 Stanley.Yang Stanley.Yang@amd.com 2022-03-21T04:50:36+00:00 urn:sha1:93dde6ccd66d29502506e95f568fd0f49d575d27 It must check asic whether support smu before call smu powerplay function, otherwise it may cause null point on no support smu asic. Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com> Reviewed-by: Evan Quan <evan.quan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-03-15T18:34:34+00:00 Stanley.Yang Stanley.Yang@amd.com 2022-03-10T13:55:09+00:00 urn:sha1:a29d44aea1aef0bc58d4951f2ddbe5b22d9a2e94 Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com> Reviewed-by: Evan Quan <evan.quan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-03-15T18:25:16+00:00 Stanley.Yang Stanley.Yang@amd.com 2022-03-03T09:51:24+00:00 urn:sha1:d510eccfa51e09f5e65621a2e8d41f58a8dbd3ba support message SMU update bad channel info to update HBM bad channel info in OOB table Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com> Reviewed-by: Tao Zhou <tao.zhou1@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-02-02T23:27:58+00:00 Darren Powell darren.powell@amd.com 2021-12-04T05:23:52+00:00 urn:sha1:5d64f9bbb6281a5a89a2266b9d39daa1fca1d6b4 (v3) Rewrote patchset to order patches as (API, hw impl, usecase) - added API for new power management function emit_clk_levels This function should duplicate the functionality of print_clk_levels, but this solution passes the buffer base and write offset down the stack. - new powerplay function emit_clock_levels, implemented by smu_emit_ppclk_levels() This function parallels the implementation of smu_print_ppclk_levels and calls emit_clk_levels, and allows the returns of errors - new helper function smu_convert_to_smuclk called by smu_print_ppclk_levels and smu_emit_ppclk_levels Signed-off-by: Darren Powell <darren.powell@amd.com> Reviewed-By: Evan Quan <evan.quan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-01-27T20:48:22+00:00 Evan Quan evan.quan@amd.com 2022-01-25T08:09:00+00:00 urn:sha1:75513bf5d72cd1a81401866642f4a8052b2d4420 The sub-routine(amdgpu_gfx_off_ctrl) tried to obtain the lock adev->pm.mutex which was actually hold by amdgpu_dpm_force_performance_level. A deadlock happened then. Signed-off-by: Evan Quan <evan.quan@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-01-14T22:52:47+00:00 Flora Cui flora.cui@amd.com 2022-01-13T06:55:24+00:00 urn:sha1:1613f346f86b25121aceb941d03ca927e57af20c check null ptr first before access its element v2: check adev->pm.dpm_enabled early in amdgpu_debugfs_pm_init() Signed-off-by: Flora Cui <flora.cui@amd.com> Reviewed-by: Evan Quan <evan.quan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-01-14T22:51:15+00:00 Evan Quan evan.quan@amd.com 2022-01-11T07:02:19+00:00 urn:sha1:685fae24d94fd615b7058832fcb437eb588f4860 On functionality unsupported, -EOPNOTSUPP will be returned. And we rely on that to determine the fan attributes support. Fixes: 79c65f3fcbb128 ("drm/amd/pm: do not expose power implementation details to amdgpu_pm.c") Signed-off-by: Evan Quan <evan.quan@amd.com> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2022-01-14T22:51:15+00:00 Alex Deucher alexander.deucher@amd.com 2022-01-07T23:14:22+00:00 urn:sha1:54c73b51df2958f564b144ce86f15a85e227db90 This is part of the forced performance level. Move it from the sysfs handler into amdgpu_dpm_force_performance_level. Reviewed-by: Evan Quan <evan.quan@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>