kernel/linux.git/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c, branch v4.14.45

drm/amdkfd: Fix kernel-queue wrapping bugs

2017-09-20T22:10:21+00:00

Avoid intermediate negative numbers when doing calculations with a mix of signed and unsigned variables where implicit conversions can lead to unexpected results. When kernel queue buffer wraps around to 0, we need to check that rptr won't be overwritten by the new packet. Signed-off-by: Yong Zhao Signed-off-by: Felix Kuehling Signed-off-by: Oded Gabbay

drm/amdkfd: Fix incorrect destroy_mqd parameter

2017-09-20T22:10:17+00:00

When uninitializing a kernel queue. Signed-off-by: Yong Zhao Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: pass queue's mqd when destroying mqd

2017-09-02T12:00:25+00:00

In VI, the destroy mqd function needs to inquire fields present in the mqd structure. That's why we need to pass it to that function instead of NULL. Signed-off-by: Oded Gabbay

drm/amd: Update MEC HQD loading code for KFD

2017-08-16T03:00:17+00:00

Various bug fixes and improvements that accumulated over the last two years. Signed-off-by: Felix Kuehling Acked-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Handle remaining BUG_ONs more gracefully v2

2017-08-16T03:00:12+00:00

In most cases, BUG_ONs can be replaced with WARN_ON with an error return. In some void functions just turn them into a WARN_ON and possibly an early exit. v2: * Cleaned up error handling in pm_send_unmap_queue * Removed redundant WARN_ON in kfd_process_destroy_delayed Signed-off-by: Felix Kuehling Signed-off-by: Oded Gabbay

drm/amdkfd: Remove BUG_ONs for NULL pointer arguments

2017-08-16T03:00:09+00:00

Remove BUG_ONs that check for NULL pointer arguments that are dereferenced in the same function. Dereferencing the NULL pointer will generate a BUG anyway, so the explicit check is redundant and unnecessary overhead. Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Remove usage of alloc(sizeof(struct...

2017-08-16T03:00:08+00:00

See https://kernel.org/doc/html/latest/process/coding-style.html under "14) Allocating Memory" for rationale behind removing the x=alloc(sizeof(struct) style and using x=alloc(sizeof(*x) instead Signed-off-by: Kent Russell Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Change x==NULL/false references to !x

2017-08-16T03:00:06+00:00

Upstream prefers the !x notation to x==NULL or x==false. Along those lines change the ==true or !=NULL references as well. Also make the references to !x the same, excluding () for readability. Signed-off-by: Kent Russell Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Consolidate and clean up log commands

2017-08-16T03:00:05+00:00

Consolidate log commands so that dev_info(NULL, "Error...") uses the more accurate pr_err, remove the module name from the log (can be seen via dynamic debugging with +m), and the function name (can be seen via dynamic debugging with +f). We also don't need debug messages saying what function we're in. Those can be added by devs when needed Don't print vendor and device ID in error messages. They are typically the same for all GPUs in a multi-GPU system. So this doesn't add any value to the message. Lastly, remove parentheses around %d, %i and 0x%llX. According to kernel.org: "Printing numbers in parentheses (%d) adds no value and should be avoided." Signed-off-by: Kent Russell Signed-off-by: Yong Zhao Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Pass 'struct queue_propertices' by reference

2016-09-19T17:58:35+00:00

Allow init_queue() to take 'struct queue_properties' by reference. Signed-off-by: Edward O'Callaghan Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay