kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c, branch v6.12.80

drm/amdgpu: Fix the uninitialized variable warning

2024-05-08T19:17:04+00:00

Check the user input and phy_id value range to fix "Using uninitialized value phy_id" Signed-off-by: Ma Jun Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher

drm/amdgpu: update ta_secureDisplay_if.h to v27.00.00.08

2023-01-05T16:43:46+00:00

1. Rename securedisplay_cmd to ta_securedisplay_cmd. 2. Rename ta_securedisplay_max_phy to ta_securedisplay_phy_ID. 3. update securedisplay_cmd to ta_securedisplay_cmd Signed-off-by: Aaron Liu Signed-off-by: Shane Xiao Reviewed-by: Alan Liu Signed-off-by: Alex Deucher

drm/amdgpu: Move the mutex_lock to protect the return status of securedisplay command buffer

2022-10-27T19:12:08+00:00

[Why] Before we call psp_securedisplay_invoke(), we call psp_prep_securedisplay_cmd_buf() to prepare and initialize the command buffer. However, we didn't use the mutex_lock to protect the status of command buffer. So when multiple threads are using the command buffer, after thread A return from psp_securedisplay_invoke() and the command buffer status is set to SUCCESS, another thread B may call psp_prep_securedisplay_cmd_buf() and initialize the status to FAILURE again, and cause Thread A to get a failure return status. [How] Move the mutex_lock out of psp_securedisplay_invoke() to its caller to cover psp_prep_securedisplay_cmd_buf() and the code checking the return status of command buffer. Signed-off-by: Alan Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher

drm/amd: consolidate TA shared memory structures

2021-08-18T22:22:53+00:00

Signed-off-by: Candice Li Reviewed-by: John Clements Signed-off-by: Alex Deucher

drm/amdgpu: Add compile flag for securedisplay

2021-05-20T02:29:49+00:00

Add compile flag CONFIG_DEBUG_FS to clear the warning: unused variable 'amdgpu_securedisplay_debugfs_ops' Signed-off-by: Jinzhou Su Acked-by: Alex Deucher Acked-by: Huang Rui Reported-by: kernel test robot Signed-off-by: Alex Deucher

amdgpu: securedisplay: simplify i2c hexdump output

2021-04-09T20:44:08+00:00

A previous fix I did left a rather complicated loop in amdgpu_securedisplay_debugfs_write() for what could be expressed in a simple sprintf, as Rasmus pointed out. This drops the leading 0x for each byte, but is otherwise much nicer. Suggested-by: Rasmus Villemoes Signed-off-by: Arnd Bergmann Signed-off-by: Alex Deucher

amdgpu: fix gcc -Wrestrict warning

2021-04-09T20:42:25+00:00

gcc warns about an sprintf() that uses the same buffer as source and destination, which is undefined behavior in C99: drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function 'amdgpu_securedisplay_debugfs_write': drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:141:6: error: 'sprintf' argument 3 overlaps destination object 'i2c_output' [-Werror=restrict] 141 | sprintf(i2c_output, "%s 0x%X", i2c_output, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 142 | securedisplay_cmd->securedisplay_out_message.send_roi_crc.i2c_buf[i]); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:97:7: note: destination object referenced by 'restrict'-qualified argument 1 was declared here 97 | char i2c_output[256]; | ^~~~~~~~~~ Rewrite it to remember the current offset into the buffer instead. Signed-off-by: Arnd Bergmann Signed-off-by: Alex Deucher

drm/amdgpu: update secure display TA header

2021-03-24T03:27:41+00:00

update secure display TA header file. Signed-off-by: Jinzhou Su Reviewed-by: Huang Rui Signed-off-by: Alex Deucher

drm/amdgpu: Add secure display TA interface

2021-01-14T04:58:14+00:00

Add interface to load, unload, invoke command for secure display TA. v2: Add debugfs interface for secure display TA v3: fix warning in copy_from_user (Alex) Signed-off-by: Jinzhou.Su Reviewed-by: Huang Rui Signed-off-by: Alex Deucher