kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c, branch v7.2-rc1Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v7.2-rc12026-06-04T19:24:13+00:00drm/amdgpu: Fix user-triggerable BUG()/BUG_ON() calls2026-06-04T19:24:13+00:00Ce Suncesun102@amd.com2026-05-18T08:44:06+00:00urn:sha1:d35617ef465b935503e4616c1ce35775a6bc1b71
Replace BUG()/BUG_ON() with error logs and safe returns in several
places where they can be triggered by invalid userspace input,
preventing DoS via kernel panic.
Signed-off-by: Ce Sun <cesun102@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: move read_indexed_register to amdgpu_reg_access2026-04-28T18:28:58+00:00Gabriel Almeidagabrielsousa230@gmail.com2026-04-24T00:49:10+00:00urn:sha1:721ee897a0470366584adc9f3ef88498f63101f0
The read_indexed_register helper is duplicated across multiple files
with identical logic.
Move it to amdgpu_reg_access.c as
amdgpu_read_indexed_register and update all users accordingly.
No functional changes intended.
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Gabriel Almeida <gabrielsousa230@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Drop unreachable return in amdgpu_reg_get_smn_base64()2026-03-17T14:45:39+00:00Srinivasan Shanmugamsrinivasan.shanmugam@amd.com2026-03-12T08:37:36+00:00urn:sha1:a782576e28ea35157f4cf97e723ea53c0ecbd6d5
amdgpu_reg_get_smn_base64() returns from all control-flow paths inside
the !adev->reg.smn.get_smn_base fallback path.
For version == 1, the function returns the base address from
amdgpu_reg_smn_v1_0_get_base(). For all other versions, the default
switch branch emits a dev_err_once() and returns 0.
The trailing return 0 after the switch is therefore unreachable and is
reported by Smatch as dead code:
drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c:317
amdgpu_reg_get_smn_base64() warn: ignoring unreachable code
Remove the redundant return statement.
Fixes: 467ebfe65f6e ("drm/amdgpu: Add smn callbacks to register block")
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Lijo Lazar <lijo.lazar@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Use get_smn_base in aqua_vanjaram2026-03-02T21:46:48+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T14:13:21+00:00urn:sha1:36a0245666882cf10ddc0576b78a33692263e417
Use get_smn_base interface to get IP die instance's base offset in
aqua_vanjaram. encode_ext_smn_addressing is not used.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add smn callbacks to register block2026-03-02T21:46:44+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T12:31:25+00:00urn:sha1:467ebfe65f6e70da92266b156c6fbf6e9e0e022f
Add smn block to register access and callback interface definition to
get smn base.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Move pcie lock to register block2026-03-02T21:46:41+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T06:02:42+00:00urn:sha1:b2d55124712b3551842bab228f27db3df8068b30
Move pcie register access lock to register access block.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add pcie64 extended to register block2026-03-02T21:46:38+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T05:58:45+00:00urn:sha1:4a6ab03731c0cb7fd9c98930ad79eb784a5c72d1
Add extended pcie 64-bit access method to register access block.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add pcie64 indirect to register block2026-03-02T21:46:34+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T05:41:41+00:00urn:sha1:74b9c49e6d8ba2586081aecd86af96c510092103
Move 64-bit pcie indirect read/writes to register access block.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add pcie ext access to register block2026-03-02T21:46:31+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T04:39:37+00:00urn:sha1:5312d68a6bdbf3546cc3fbea0fb5d283b28aabbe
Move pcie extended access (64-bit address) to register access block.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add pcie indirect to register block2026-03-02T21:46:28+00:00Lijo Lazarlijo.lazar@amd.com2025-12-09T04:17:13+00:00urn:sha1:e84d7e717bf94bd977e20e5ca52d0b2ae4e19802
Move pcie indirect access to register access block.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>