kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c, branch v6.12.80Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.802026-03-04T12:20:42+00:00drm/amdgpu: Fix memory leak in amdgpu_ras_init()2026-03-04T12:20:42+00:00Zilin Guanzilin@seu.edu.cn2026-01-29T08:35:15+00:00urn:sha1:c11cd77a18115d2cd3f4b6915c4a537b6042f950
[ Upstream commit ee41e5b63c8210525c936ee637a2c8d185ce873c ]
When amdgpu_nbio_ras_sw_init() fails in amdgpu_ras_init(), the function
returns directly without freeing the allocated con structure, leading
to a memory leak.
Fix this by jumping to the release_con label to properly clean up the
allocated memory before returning the error code.
Compile tested only. Issue found using a prototype static analysis tool
and code review.
Fixes: fdc94d3a8c88 ("drm/amdgpu: Rework pcie_bif ras sw_init")
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drm/amdgpu: Avoid rma causes GPU duplicate reset2025-11-13T20:34:09+00:00Ce Suncesun102@amd.com2025-07-27T04:06:55+00:00urn:sha1:55fadcd04ed2ec36f889e1fc573051b6a6bda1bc
[ Upstream commit 21c0ffa612c98bcc6dab5bd9d977a18d565ee28e ]
Try to ensure poison creation handle is completed in time
to set device rma value.
Signed-off-by: Ce Sun <cesun102@amd.com>
Signed-off-by: Stanley.Yang <Stanley.Yang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drm/amdgpu: add range check for RAS bad page address2025-11-13T20:34:09+00:00Tao Zhoutao.zhou1@amd.com2025-07-02T08:16:02+00:00urn:sha1:9cb03fb9ec46e4e234fb6fe4d2a4eb92f3faf24c
[ Upstream commit 2b17c240e8cd9ac61d3c82277fbed27edad7f002 ]
Exclude invalid bad pages.
Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drm/amdgpu: fix typo in the comment2024-09-18T20:14:26+00:00Yan Zhenyanzhen@vivo.com2024-09-11T04:27:38+00:00urn:sha1:0110ac11952f06419d267f51a3989e989b17e67a
Correctly spelled comments make it easier for the reader to understand
the code.
Replace 'udpate' with 'update' in the comment &
replace 'recieved' with 'received' in the comment &
replace 'dsiable' with 'disable' in the comment &
replace 'Initiailize' with 'Initialize' in the comment &
replace 'disble' with 'disable' in the comment &
replace 'Disbale' with 'Disable' in the comment &
replace 'enogh' with 'enough' in the comment &
replace 'availabe' with 'available' in the comment.
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: disable GPU RAS bad page feature for specific ASIC2024-09-17T14:04:57+00:00Tao Zhoutao.zhou1@amd.com2024-09-09T10:51:42+00:00urn:sha1:c389a0604cfbcdb1f8f53a76560eb31e0700e206
The feature is not applicable to specific app platform.
v2: update the disablement condition and commit description
v3: move the setting to amdgpu_ras_check_supported
Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: remove RAS unused paramter 'err_addr'2024-08-06T15:11:01+00:00Yang Wangkevinyang.wang@amd.com2024-08-02T02:11:37+00:00urn:sha1:671af06690e7f79db51b475a35c3b2619f345abc
- amdgpu_ras_error_statistic_ue_count()
- amdgpu_ras_error_statistic_ce_count()
- amdgpu_ras_error_statistic_de_count()
The parameter 'err_addr' is no longer used since following patch.
Fixes: a7e8467fbeee ("drm/amdgpu: Remove unused code")
Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: create function to check RAS RMA status2024-08-06T15:11:01+00:00Tao Zhoutao.zhou1@amd.com2024-08-01T06:26:19+00:00urn:sha1:792be2e23ac69821db7860ba4ba94592101f0b07
In the convenience of calling it globally.
Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add more types for boot time error reporting2024-08-06T15:10:17+00:00Hawking ZhangHawking.Zhang@amd.com2024-08-01T05:45:27+00:00urn:sha1:dfe9d047b162f3a79ab63046608c693ee14c5b7a
Data abort exception and unknown errors are supported.
Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Remove unused code2024-07-23T21:32:20+00:00YiPeng ChaiYiPeng.Chai@amd.com2024-07-11T08:27:08+00:00urn:sha1:a7e8467fbeee654e390aad1736291d273b407a2c
Remove unused code.
Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: timely save bad pages to eeprom after gpu ras reset is completed2024-07-10T14:13:41+00:00YiPeng ChaiYiPeng.Chai@amd.com2024-07-02T09:53:02+00:00urn:sha1:e23300dfffa178b19abc1b1b94ed7de74b0e0930
The problem case is as follows:
1. GPU A triggers a gpu ras reset, and GPU A drives
GPU B to also perform a gpu ras reset.
2. After gpu B ras reset started, gpu B queried a DE
data. Since the DE data was queried in the ras reset
thread instead of the page retirement thread, bad
page retirement work would not be triggered. Then
even if all gpu resets are completed, the bad pages
will be cached in RAM until GPU B's bad page retirement
work is triggered again and then saved to eeprom.
This patch can save the bad pages to eeprom in time after gpu
ras reset is completed.
v2:
1. Add the above description to code comments.
2. Reuse existing function.
Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>