kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c, branch v6.12.81Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.812023-03-13T21:27:48+00:00drm/amdgpu: Move mmhub ras block init to ras sw_init2023-03-13T21:27:48+00:00Hawking ZhangHawking.Zhang@amd.com2023-03-04T08:39:48+00:00urn:sha1:fec70a8601a76272b08b7b8077b3c3e3c79bdb72
Initialize mmhub ras block only when mmhub ip block
supports ras features. Driver queries ras capabilities
after early_init, ras block init needs to be moved to
sw_init.
Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Stanley Yang <Stanley.Yang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: fixed the warnings reported by kernel test robot2022-03-15T18:42:20+00:00yipechaiYiPeng.Chai@amd.com2022-03-11T08:54:20+00:00urn:sha1:8476269f758221863c01a0a6cccb0d75ec5d60c3
The reported warnings are as follows:
1.warning:no-previous-prototype-for-amdgpu_hdp_ras_fini.
2.warning:no-previous-prototype-for-amdgpu_mmhub_ras_fini.
Amdgpu_hdp_ras_fini and amdgpu_mmhub_ras_fini are unused
in the code, they are the only functions in amdgpu_hdp.c
and amdgpu_mmhub.c. After removing these two functions,
both amdgpu_hdp.c and amdgpu_mmhub.c are empty, so these
two files can be deleted to fix the warning.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in mmhub ras block2022-03-02T23:40:05+00:00yipechaiYiPeng.Chai@amd.com2022-02-14T08:01:02+00:00urn:sha1:9dad47c50f9bf19153c092a73eb4721344f4a78d
Remove redundant calls of amdgpu_ras_block_late_fini in mmhub ras block.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Optimize xxx_ras_fini function of each ras block2022-03-02T23:40:05+00:00yipechaiYiPeng.Chai@amd.com2022-02-17T06:55:19+00:00urn:sha1:667c7091a39e8b360d34f37aed5f8dd85bdc45f7
1. Move the variables of ras block instance members from
specific xxx_ras_fini to general ras_fini call.
2. Function calls inside the modules only use parameters
passed from xxx_ras_fini instead of ras block instance
members.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Modify .ras_fini function pointer parameter2022-03-02T23:40:05+00:00yipechaiYiPeng.Chai@amd.com2022-02-17T06:52:20+00:00urn:sha1:01d468d9a420152e4a1270992e69a37ea0c98e04
Modify .ras_fini function pointer parameter so that
we can remove redundant intermediate calls in some
ras blocks.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Remove redundant calls of ras_late_init in mmhub ras block2022-02-17T20:59:04+00:00yipechaiYiPeng.Chai@amd.com2022-02-14T06:20:31+00:00urn:sha1:068001b711e820184553e90f9bf2ae18fb4c2c06
Remove redundant calls of ras_late_init in mmhub ras block.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Modify .ras_late_init function pointer parameter2022-02-17T20:59:04+00:00yipechaiYiPeng.Chai@amd.com2022-02-14T06:12:55+00:00urn:sha1:4e9b1fa5a2757d11a5c40eed2b2b4837dcb2f12e
Modify .ras_late_init function pointer parameter so that
it can remove redundant intermediate calls in some ras blocks.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Optimize amdgpu_mmhub_ras_late_init/amdgpu_mmhub_ras_fini function code2022-02-14T20:08:41+00:00yipechaiYiPeng.Chai@amd.com2022-02-08T02:42:47+00:00urn:sha1:cb9561d0e3f4393a31fab2034c33c6cf2162513a
Optimize amdgpu_mmhub_ras_late_init/amdgpu_mmhub_ras_fini function code.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Modify mmhub block to fit for the unified ras block data and ops2022-01-14T22:51:59+00:00yipechaiYiPeng.Chai@amd.com2022-01-04T11:04:41+00:00urn:sha1:5e67bba301156c85251f49df19f5c695875814d1
1.Modify mmhub block to fit for the unified ras block data and ops.
2.Change amdgpu_mmhub_ras_funcs to amdgpu_mmhub_ras, and the corresponding variable name remove _funcs suffix.
3.Remove the const flag of mmhub ras variable so that mmhub ras block can be able to be inserted into amdgpu device ras block link list.
4.Invoke amdgpu_ras_register_ras_block function to register mmhub ras block into amdgpu device ras block link list. 5.Remove the redundant code about mmhub in amdgpu_ras.c after using the unified ras block.
5.Remove the redundant code about mmhub in amdgpu_ras.c after using the unified ras block.
6.Fill unified ras block .name .block .ras_late_init and .ras_fini for all of mmhub versions. If .ras_late_init and .ras_fini had been defined by the selected mmhub version, the defined functions will take effect; if not defined, default fill them with amdgpu_mmhub_ras_late_init and amdgpu_mmhub_ras_fini.
Signed-off-by: yipechai <YiPeng.Chai@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: John Clements <john.clements@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/amdgpu: remove unnecessary RAS context field2021-08-16T19:35:55+00:00Candice Licandice.li@amd.com2021-08-13T11:06:33+00:00urn:sha1:893cf382c0403d7c4581f0f01f6d06c76485123d
Delete ras_if->name in the RAS ctx structure and remove related lines.
Signed-off-by: Candice Li <candice.li@amd.com>
Reviewed-by: John Clements <john.clements@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>